* [PATCH] rtl8xxxu: prevent leaking urb
@ 2019-09-20 3:00 Navid Emamdoost
2019-09-20 10:23 ` Chris Chiu
2019-10-02 4:32 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Navid Emamdoost @ 2019-09-20 3:00 UTC (permalink / raw)
Cc: emamd001, smccaman, kjlu, Navid Emamdoost, Jes Sorensen,
Kalle Valo, David S. Miller, linux-wireless, netdev,
linux-kernel
In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
should be released.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 8136e268b4e6..4a559c37e208 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5443,6 +5443,7 @@ static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw)
ret = usb_submit_urb(urb, GFP_KERNEL);
if (ret) {
usb_unanchor_urb(urb);
+ usb_free_urb(urb);
goto error;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8xxxu: prevent leaking urb
2019-09-20 3:00 [PATCH] rtl8xxxu: prevent leaking urb Navid Emamdoost
@ 2019-09-20 10:23 ` Chris Chiu
2019-10-02 4:32 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Chris Chiu @ 2019-09-20 10:23 UTC (permalink / raw)
To: Navid Emamdoost
Cc: emamd001, smccaman, kjlu, Jes Sorensen, Kalle Valo,
David S. Miller, linux-wireless, netdev, Linux Kernel
On Fri, Sep 20, 2019 at 11:01 AM Navid Emamdoost
<navid.emamdoost@gmail.com> wrote:
>
> In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
> should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Chris Chiu <chiu@endlessm.com>
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -5443,6 +5443,7 @@ static int rtl8xxxu_submit_int_urb(struct ieee80211_hw *hw)
> ret = usb_submit_urb(urb, GFP_KERNEL);
> if (ret) {
> usb_unanchor_urb(urb);
> + usb_free_urb(urb);
> goto error;
> }
You're right. There's a usb_alloc_urb in the beginning of this
function and should be
handled after submit failure.
Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8xxxu: prevent leaking urb
2019-09-20 3:00 [PATCH] rtl8xxxu: prevent leaking urb Navid Emamdoost
2019-09-20 10:23 ` Chris Chiu
@ 2019-10-02 4:32 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-10-02 4:32 UTC (permalink / raw)
To: Navid Emamdoost
Navid Emamdoost <navid.emamdoost@gmail.com> wrote:
> In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb
> should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> Reviewed-by: Chris Chiu <chiu@endlessm.com>
Patch applied to wireless-drivers-next.git, thanks.
a2cdd07488e6 rtl8xxxu: prevent leaking urb
--
https://patchwork.kernel.org/patch/11153733/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-02 4:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 3:00 [PATCH] rtl8xxxu: prevent leaking urb Navid Emamdoost
2019-09-20 10:23 ` Chris Chiu
2019-10-02 4:32 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).