From: <yhchuang@realtek.com>
To: <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: [PATCH 11/14] rtw88: raise firmware version debug level
Date: Wed, 2 Oct 2019 14:35:28 +0800 [thread overview]
Message-ID: <20191002063531.18135-12-yhchuang@realtek.com> (raw)
In-Reply-To: <20191002063531.18135-1-yhchuang@realtek.com>
From: Yan-Hsuan Chuang <yhchuang@realtek.com>
It's better to print firmware version at load time.
But since we need to set debug_mask properly to default print
rtw_dbg(), raise the debug level to rtw_info() instead.
Also change the multiple line style to one line only, it will
be easier for log analyzing.
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
drivers/net/wireless/realtek/rtw88/mac.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
index f40877bc9c9a..75f35a97dca7 100644
--- a/drivers/net/wireless/realtek/rtw88/mac.c
+++ b/drivers/net/wireless/realtek/rtw88/mac.c
@@ -578,10 +578,8 @@ static void update_firmware_info(struct rtw_dev *rtwdev,
fw->sub_version = *(data + FW_HDR_SUBVERSION);
fw->sub_index = *(data + FW_HDR_SUBINDEX);
- rtw_dbg(rtwdev, RTW_DBG_FW, "fw h2c version: %x\n", fw->h2c_version);
- rtw_dbg(rtwdev, RTW_DBG_FW, "fw version: %x\n", fw->version);
- rtw_dbg(rtwdev, RTW_DBG_FW, "fw sub version: %x\n", fw->sub_version);
- rtw_dbg(rtwdev, RTW_DBG_FW, "fw sub index: %x\n", fw->sub_index);
+ rtw_info(rtwdev, "Firmware version %u.%u.%u, H2C version %u\n",
+ fw->version, fw->sub_version, fw->sub_index, fw->h2c_version);
}
static int
--
2.17.1
next prev parent reply other threads:[~2019-10-02 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 6:35 [PATCH 00/14] rtw88: add software TX queue support yhchuang
2019-10-02 6:35 ` [PATCH 01/14] rtw88: check firmware leave lps successfully yhchuang
2019-10-04 13:45 ` Kalle Valo
2019-10-02 6:35 ` [PATCH 02/14] rtw88: allows to set RTS in TX descriptor yhchuang
2019-10-02 6:35 ` [PATCH 03/14] rtw88: add driver TX queue support yhchuang
2019-10-02 6:35 ` [PATCH 04/14] rtw88: take over rate control from mac80211 yhchuang
2019-10-02 6:35 ` [PATCH 05/14] rtw88: report tx rate to mac80211 stack yhchuang
2019-10-02 6:35 ` [PATCH 06/14] rtw88: add TX-AMSDU support yhchuang
2019-10-02 6:35 ` [PATCH 07/14] rtw88: flush hardware tx queues yhchuang
2019-10-02 6:35 ` [PATCH 08/14] rtw88: fix beaconing mode rsvd_page memory violation issue yhchuang
2019-10-02 6:35 ` [PATCH 09/14] rtw88: Don't set RX_FLAG_DECRYPTED if packet has no encryption yhchuang
2019-10-02 6:35 ` [PATCH 10/14] rtw88: configure TX queue EDCA parameters yhchuang
2019-10-02 6:35 ` yhchuang [this message]
2019-10-02 6:35 ` [PATCH 12/14] rtw88: use struct rtw_fw_hdr to access firmware header yhchuang
2019-10-02 6:35 ` [PATCH 13/14] rtw88: fix NSS of hw_cap yhchuang
2019-10-02 6:35 ` [PATCH 14/14] rtw88: fix error handling when setup efuse info yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002063531.18135-12-yhchuang@realtek.com \
--to=yhchuang@realtek.com \
--cc=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).