* [PATCH] rtw88: signal completion even on firmware-request failure
@ 2019-11-06 21:30 Brian Norris
2019-11-07 3:31 ` Tony Chuang
2019-11-08 8:27 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2019-11-06 21:30 UTC (permalink / raw)
To: linux-wireless; +Cc: Yan-Hsuan Chuang, Brian Norris, Dan Carpenter
Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever.
Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware")
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/net/wireless/realtek/rtw88/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index de82d08ea29e..ae61415e1665 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1026,6 +1026,7 @@ static void rtw_load_firmware_cb(const struct firmware *firmware, void *context)
if (!firmware || !firmware->data) {
rtw_err(rtwdev, "failed to request firmware\n");
+ complete_all(&fw->completion);
return;
}
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rtw88: signal completion even on firmware-request failure
2019-11-06 21:30 [PATCH] rtw88: signal completion even on firmware-request failure Brian Norris
@ 2019-11-07 3:31 ` Tony Chuang
2019-11-08 8:27 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Tony Chuang @ 2019-11-07 3:31 UTC (permalink / raw)
To: Brian Norris, linux-wireless; +Cc: Dan Carpenter
> Subject: [PATCH] rtw88: signal completion even on firmware-request failure
>
> Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever.
>
> Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware")
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw88: signal completion even on firmware-request failure
2019-11-06 21:30 [PATCH] rtw88: signal completion even on firmware-request failure Brian Norris
2019-11-07 3:31 ` Tony Chuang
@ 2019-11-08 8:27 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-11-08 8:27 UTC (permalink / raw)
To: Brian Norris
Cc: linux-wireless, Yan-Hsuan Chuang, Brian Norris, Dan Carpenter
Brian Norris <briannorris@chromium.org> wrote:
> Otherwise, the waiters (e.g., "modprobe rtwpci") will block forever.
>
> Fixes: f530c1961af2 ("rtw88: fix potential NULL pointer access for firmware")
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
21c60a28af58 rtw88: signal completion even on firmware-request failure
--
https://patchwork.kernel.org/patch/11231189/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 21:30 [PATCH] rtw88: signal completion even on firmware-request failure Brian Norris
2019-11-07 3:31 ` Tony Chuang
2019-11-08 8:27 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).