* [PATCH] rtw88: Make two functions static
@ 2020-03-28 3:05 YueHaibing
2020-04-14 15:01 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-03-28 3:05 UTC (permalink / raw)
To: yhchuang, kvalo, davem; +Cc: linux-wireless, netdev, linux-kernel, YueHaibing
Fix sparse warnings:
drivers/net/wireless/realtek/rtw88/fw.c:633:4: warning:
symbol 'rtw_get_rsvd_page_probe_req_location' was not declared. Should it be static?
drivers/net/wireless/realtek/rtw88/fw.c:650:5: warning:
symbol 'rtw_get_rsvd_page_probe_req_size' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 05c430b3489c..9192ab26e39b 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -630,8 +630,8 @@ void rtw_fw_set_pg_info(struct rtw_dev *rtwdev)
rtw_fw_send_h2c_command(rtwdev, h2c_pkt);
}
-u8 rtw_get_rsvd_page_probe_req_location(struct rtw_dev *rtwdev,
- struct cfg80211_ssid *ssid)
+static u8 rtw_get_rsvd_page_probe_req_location(struct rtw_dev *rtwdev,
+ struct cfg80211_ssid *ssid)
{
struct rtw_rsvd_page *rsvd_pkt;
u8 location = 0;
@@ -647,8 +647,8 @@ u8 rtw_get_rsvd_page_probe_req_location(struct rtw_dev *rtwdev,
return location;
}
-u16 rtw_get_rsvd_page_probe_req_size(struct rtw_dev *rtwdev,
- struct cfg80211_ssid *ssid)
+static u16 rtw_get_rsvd_page_probe_req_size(struct rtw_dev *rtwdev,
+ struct cfg80211_ssid *ssid)
{
struct rtw_rsvd_page *rsvd_pkt;
u16 size = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtw88: Make two functions static
2020-03-28 3:05 [PATCH] rtw88: Make two functions static YueHaibing
@ 2020-04-14 15:01 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-04-14 15:01 UTC (permalink / raw)
To: YueHaibing
Cc: yhchuang, davem, linux-wireless, netdev, linux-kernel, YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> Fix sparse warnings:
>
> drivers/net/wireless/realtek/rtw88/fw.c:633:4: warning:
> symbol 'rtw_get_rsvd_page_probe_req_location' was not declared. Should it be static?
> drivers/net/wireless/realtek/rtw88/fw.c:650:5: warning:
> symbol 'rtw_get_rsvd_page_probe_req_size' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
ca2c6881dcca rtw88: Make two functions static
--
https://patchwork.kernel.org/patch/11463395/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-14 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28 3:05 [PATCH] rtw88: Make two functions static YueHaibing
2020-04-14 15:01 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).