* [PATCH] wireless: cw1200: make cw1200_spi_irq_unsubscribe() void
@ 2020-04-10 9:09 Jason Yan
2020-04-15 8:38 ` [PATCH] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-10 9:09 UTC (permalink / raw)
To: pizza, kvalo, davem, linux-wireless, netdev, linux-kernel; +Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/wireless/st/cw1200/cw1200_spi.c:273:5-8: Unneeded variable:
"ret". Return "0" on line 279
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/wireless/st/cw1200/cw1200_spi.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/st/cw1200/cw1200_spi.c b/drivers/net/wireless/st/cw1200/cw1200_spi.c
index ef01caac629c..271ed2ce2d7f 100644
--- a/drivers/net/wireless/st/cw1200/cw1200_spi.c
+++ b/drivers/net/wireless/st/cw1200/cw1200_spi.c
@@ -268,15 +268,11 @@ static int cw1200_spi_irq_subscribe(struct hwbus_priv *self)
return ret;
}
-static int cw1200_spi_irq_unsubscribe(struct hwbus_priv *self)
+static void cw1200_spi_irq_unsubscribe(struct hwbus_priv *self)
{
- int ret = 0;
-
pr_debug("SW IRQ unsubscribe\n");
disable_irq_wake(self->func->irq);
free_irq(self->func->irq, self);
-
- return ret;
}
static int cw1200_spi_off(const struct cw1200_platform_data_spi *pdata)
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cw1200: make cw1200_spi_irq_unsubscribe() void
2020-04-10 9:09 [PATCH] wireless: cw1200: make cw1200_spi_irq_unsubscribe() void Jason Yan
@ 2020-04-15 8:38 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-04-15 8:38 UTC (permalink / raw)
To: Jason Yan; +Cc: pizza, davem, linux-wireless, netdev, linux-kernel, Jason Yan
Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/st/cw1200/cw1200_spi.c:273:5-8: Unneeded variable:
> "ret". Return "0" on line 279
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
80efb443ea03 cw1200: make cw1200_spi_irq_unsubscribe() void
--
https://patchwork.kernel.org/patch/11483037/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 9:09 [PATCH] wireless: cw1200: make cw1200_spi_irq_unsubscribe() void Jason Yan
2020-04-15 8:38 ` [PATCH] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).