linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock
@ 2020-04-27  9:24 Wei Yongjun
  2020-04-27  9:38 ` Kalle Valo
  2020-04-28  9:14 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-04-27  9:24 UTC (permalink / raw)
  To: Kalle Valo, Sumit Semwal
  Cc: Wei Yongjun, ath11k, linux-wireless, linux-media, dri-devel,
	linaro-mm-sig, kernel-janitors

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index f74a0e74bf3e..34b1e8e6a7fb 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -892,7 +892,7 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
 	else
 		hw_desc_sz = ath11k_hal_reo_qdesc_size(DP_BA_WIN_SZ_MAX, tid);
 
-	vaddr = kzalloc(hw_desc_sz + HAL_LINK_DESC_ALIGN - 1, GFP_KERNEL);
+	vaddr = kzalloc(hw_desc_sz + HAL_LINK_DESC_ALIGN - 1, GFP_ATOMIC);
 	if (!vaddr) {
 		spin_unlock_bh(&ab->base_lock);
 		return -ENOMEM;




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock
  2020-04-27  9:24 [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock Wei Yongjun
@ 2020-04-27  9:38 ` Kalle Valo
  2020-04-28  9:14 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-04-27  9:38 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Sumit Semwal, kernel-janitors, linux-wireless, dri-devel,
	linaro-mm-sig, ath11k, linux-media

Wei Yongjun <weiyongjun1@huawei.com> writes:

> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Do note that ath11k patches go to my ath.git tree, not net-next. But no
need to resend because of this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock
  2020-04-27  9:24 [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock Wei Yongjun
  2020-04-27  9:38 ` Kalle Valo
@ 2020-04-28  9:14 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-04-28  9:14 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Sumit Semwal, Wei Yongjun, ath11k, linux-wireless, linux-media,
	dri-devel, linaro-mm-sig, kernel-janitors

Wei Yongjun <weiyongjun1@huawei.com> wrote:

> A spin lock is taken here so we should use GFP_ATOMIC.
> 
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

69c93f9674c9 ath11k: use GFP_ATOMIC under spin lock

-- 
https://patchwork.kernel.org/patch/11511711/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-28  9:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27  9:24 [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock Wei Yongjun
2020-04-27  9:38 ` Kalle Valo
2020-04-28  9:14 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).