From: Kalle Valo <kvalo@codeaurora.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe()
Date: Tue, 28 Apr 2020 09:28:01 +0000 (UTC) [thread overview]
Message-ID: <20200428092801.224E1C433F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200427104403.14598-1-weiyongjun1@huawei.com>
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I don't see harm having two error messages and having an error message
within ath11k makes it easier to find the exact location, so I'm
dropping this.
--
https://patchwork.kernel.org/patch/11511845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-04-28 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:44 [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() Wei Yongjun
2020-04-28 9:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428092801.224E1C433F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).