mwifiex: Firmware name for W8997 sdio wifi chip

mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

Hello!

There is inconsistency in firmware naming for W8997 SDIO wifi chip.

Firmware for this chip is stored in linux-firmware [1] repository under
filename sdsd8997_combo_v4.bin.

But mainline linux kernel driver mwifiex_sdio.ko [2] expects and loads
firmware for this chip from filename sd8997_uapsta.bin.

So result is that W8997 SDIO wifi chip does not work out of box and
people are complaining where to get "sd8997_uapsta.bin" firmware file as
it does not exist [3]. People suggest to rename it.

Do you have any opinion how to solve this problem?

As Marvell is using sdsd8997_combo_v4.bin name for this firmware I would
suggest to extend mwifiex_sdio.ko Linux driver to load this firmware
also from the file sdsd8997_combo_v4.bin.

Also firmware file sdsd8997_combo_v4.bin in linux-firmware git
repository [1] is in version 16.68.1.p179. But there is already newer
version available (e.g. 16.68.1.p197) . Are you able to update firmware
for W8997 SDIO chip in linux-firmware repository to the lasted version?

[1] - https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mrvl
[2] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/marvell/mwifiex/sdio.h?h=v5.6#n41
[3] - https://raspberrypi.stackexchange.com/q/93478

RE: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Ganapathi Bhat]

Hi Pali,

Thanks for this notice. We will try to push the new firmware and also, fix the naming problem.

Regards,
Ganapathi

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Saturday 16 May 2020 08:17:17 Ganapathi Bhat wrote:
> Hi Pali,
> 
> Thanks for this notice. We will try to push the new firmware and also, fix the naming problem.
> 
> Regards,
> Ganapathi

Thank you! Please consider extending kernel driver to load firmware
from filename sdsd8997_combo_v4.bin which is already stored in
linux-firmware repository. Also this is name which is used by marvell
(out-of-tree) kernel driver mlan.ko/sd8997.ko.

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Saturday 16 May 2020 08:17:17 Ganapathi Bhat wrote:
> Hi Pali,
> 
> Thanks for this notice. We will try to push the new firmware and also, fix the naming problem.
> 
> Regards,
> Ganapathi

Hello Ganapathi!

According to publicly available information, firmware for these W8xxx
Marvell wifi chips is vulnerable to security issue CVE-2019-6496 [1].

Are you able to update firmwares to the last versions and give us some
information which (old) firmware versions are affected by that security
issue?

So Linux distribution would know if they are distributing older
vulnerable firmwares and should push security fixes with new firmware
versions.

[1] - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6496

RE: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Ganapathi Bhat]

Hi Pali,

> According to publicly available information, firmware for these W8xxx
> Marvell wifi chips is vulnerable to security issue CVE-2019-6496 [1].
> 
> Are you able to update firmwares to the last versions and give us some
> information which (old) firmware versions are affected by that security issue?
> 
> So Linux distribution would know if they are distributing older vulnerable
> firmwares and should push security fixes with new firmware versions.
> 

88W8787, 88W8797, 88W8801, 88W8897, and 88W8997 models are all already updated, with one exception:
usb8897_uapsta.bin, which we will upstream soon;

Regards,
Ganapathi

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Friday 29 May 2020 08:43:56 Ganapathi Bhat wrote:
> Hi Pali,
> 
> > According to publicly available information, firmware for these W8xxx
> > Marvell wifi chips is vulnerable to security issue CVE-2019-6496 [1].
> > 
> > Are you able to update firmwares to the last versions and give us some
> > information which (old) firmware versions are affected by that security issue?
> > 
> > So Linux distribution would know if they are distributing older vulnerable
> > firmwares and should push security fixes with new firmware versions.
> > 
> 
> 88W8787, 88W8797, 88W8801, 88W8897, and 88W8997 models are all already updated, with one exception:
> usb8897_uapsta.bin, which we will upstream soon;

Hello Ganapathi! Thank you for information. Can you point me to git tree
or location where are firmware files already updated?

RE: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Ganapathi Bhat]

Hi Pali,
 
> Hello Ganapathi! Thank you for information. Can you point me to git tree or
> location where are firmware files already updated?

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git

or

https://github.com/NXP/mwifiex-firmware


Regards,
Ganapathi

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Friday 29 May 2020 08:49:18 Ganapathi Bhat wrote:
> Hi Pali,
>  
> > Hello Ganapathi! Thank you for information. Can you point me to git tree or
> > location where are firmware files already updated?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
> 
> or
> 
> https://github.com/NXP/mwifiex-firmware

Hello Ganapathi! Seems that on both locations is older version of
sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
available just version 16.68.1.p179. But we have newer version
16.68.1.p197. Could you please recheck it?

RE: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Ganapathi Bhat]

Hi Pali,
 
> Hello Ganapathi! Seems that on both locations is older version of
> sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
> available just version 16.68.1.p179. But we have newer version 16.68.1.p197.
> Could you please recheck it?

p179 do have the fix but we will try to upstream p197 also soon.

Regards,
Ganapathi

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Friday 29 May 2020 09:11:08 Ganapathi Bhat wrote:
> Hi Pali,
>  
> > Hello Ganapathi! Seems that on both locations is older version of
> > sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
> > available just version 16.68.1.p179. But we have newer version 16.68.1.p197.
> > Could you please recheck it?
> 
> p179 do have the fix but we will try to upstream p197 also soon.

Thank you!

Re: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Pali Rohár]

On Friday 29 May 2020 11:12:11 Pali Rohár wrote:
> On Friday 29 May 2020 09:11:08 Ganapathi Bhat wrote:
> > Hi Pali,
> >  
> > > Hello Ganapathi! Seems that on both locations is older version of
> > > sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
> > > available just version 16.68.1.p179. But we have newer version 16.68.1.p197.
> > > Could you please recheck it?
> > 
> > p179 do have the fix but we will try to upstream p197 also soon.
> 
> Thank you!

Hello Ganapathi! Do you have any updates about upstreaming new firmware version?

RE: [EXT] mwifiex: Firmware name for W8997 sdio wifi chip

[Ganapathi Bhat]

Hi Pali,

> > > > Hello Ganapathi! Seems that on both locations is older version of
> > > > sdsd8997_combo_v4.bin firmware, not the latest one. On both
> > > > location is available just version 16.68.1.p179. But we have newer
> version 16.68.1.p197.

Where did you find p197, kindly let me know so that I can try to get it's details and upstream.

> > > > Could you please recheck it?
> > >
> > > p179 do have the fix but we will try to upstream p197 also soon.
> >
> > Thank you!
> 
> Hello Ganapathi! Do you have any updates about upstreaming new firmware
> version?

Regards,
Ganapathi