* [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config
@ 2020-05-20 12:46 Dinghao Liu
2020-05-20 18:51 ` Tony Lindgren
2020-05-29 17:34 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2020-05-20 12:46 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Kalle Valo, David S. Miller, Jakub Kicinski, Thomas Gleixner,
Johannes Berg, Emmanuel Grumbach, Fuqian Huang,
Jason A. Donenfeld, Tony Lindgren, Maital Hahn, linux-wireless,
netdev, linux-kernel
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/net/wireless/ti/wlcore/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index f140f7d7f553..c7e4f5a80b9e 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3662,8 +3662,10 @@ void wlcore_regdomain_config(struct wl1271 *wl)
goto out;
ret = pm_runtime_get_sync(wl->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_autosuspend(wl->dev);
goto out;
+ }
ret = wlcore_cmd_regdomain_config_locked(wl);
if (ret < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config
2020-05-20 12:46 [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config Dinghao Liu
@ 2020-05-20 18:51 ` Tony Lindgren
2020-05-29 17:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-05-20 18:51 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Kalle Valo, David S. Miller, Jakub Kicinski,
Thomas Gleixner, Johannes Berg, Emmanuel Grumbach, Fuqian Huang,
Jason A. Donenfeld, Maital Hahn, linux-wireless, netdev,
linux-kernel
* Dinghao Liu <dinghao.liu@zju.edu.cn> [200520 12:47]:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config
2020-05-20 12:46 [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config Dinghao Liu
2020-05-20 18:51 ` Tony Lindgren
@ 2020-05-29 17:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-29 17:34 UTC (permalink / raw)
To: Dinghao Liu
Cc: dinghao.liu, kjlu, David S. Miller, Jakub Kicinski,
Thomas Gleixner, Johannes Berg, Emmanuel Grumbach, Fuqian Huang,
Jason A. Donenfeld, Tony Lindgren, Maital Hahn, linux-wireless,
netdev, linux-kernel
Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> Acked-by: Tony Lindgren <tony@atomide.com>
Patch applied to wireless-drivers-next.git, thanks.
282a04bf1d80 wlcore: fix runtime pm imbalance in wlcore_regdomain_config
--
https://patchwork.kernel.org/patch/11560391/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-29 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 12:46 [PATCH] wlcore: fix runtime pm imbalance in wlcore_regdomain_config Dinghao Liu
2020-05-20 18:51 ` Tony Lindgren
2020-05-29 17:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).