* [PATCH] mwifiex: Parse all API_VER_ID properties
@ 2020-05-21 12:34 Pali Rohár
2020-05-28 10:28 ` Pali Rohár
2020-05-29 17:41 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Pali Rohár @ 2020-05-21 12:34 UTC (permalink / raw)
To: Amitkumar Karwar, Ganapathi Bhat, Xinming Hu
Cc: Kalle Valo, David S. Miller, Marek Behún, linux-wireless,
netdev, linux-kernel
During initialization of SD8997 wifi chip kernel prints warnings:
mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
This patch adds support for parsing all api ids provided by SD8997
firmware.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++--
drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index 7e4b8cd52..589cc5eb1 100644
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
adapter->fw_api_ver =
api_rev->major_ver;
mwifiex_dbg(adapter, INFO,
- "Firmware api version %d\n",
- adapter->fw_api_ver);
+ "Firmware api version %d.%d\n",
+ adapter->fw_api_ver,
+ api_rev->minor_ver);
+ break;
+ case UAP_FW_API_VER_ID:
+ mwifiex_dbg(adapter, INFO,
+ "uAP api version %d.%d\n",
+ api_rev->major_ver,
+ api_rev->minor_ver);
+ break;
+ case CHANRPT_API_VER_ID:
+ mwifiex_dbg(adapter, INFO,
+ "channel report api version %d.%d\n",
+ api_rev->major_ver,
+ api_rev->minor_ver);
break;
default:
mwifiex_dbg(adapter, FATAL,
diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
index a415d73a7..6f86f5b96 100644
--- a/drivers/net/wireless/marvell/mwifiex/fw.h
+++ b/drivers/net/wireless/marvell/mwifiex/fw.h
@@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {
enum API_VER_ID {
KEY_API_VER_ID = 1,
FW_API_VER_ID = 2,
+ UAP_FW_API_VER_ID = 3,
+ CHANRPT_API_VER_ID = 4,
};
struct hw_spec_api_rev {
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mwifiex: Parse all API_VER_ID properties
2020-05-21 12:34 [PATCH] mwifiex: Parse all API_VER_ID properties Pali Rohár
@ 2020-05-28 10:28 ` Pali Rohár
2020-05-29 3:47 ` [EXT] " Ganapathi Bhat
2020-05-29 17:41 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Pali Rohár @ 2020-05-28 10:28 UTC (permalink / raw)
To: Amitkumar Karwar, Ganapathi Bhat, Xinming Hu
Cc: Kalle Valo, David S. Miller, Marek Behún, linux-wireless,
netdev, linux-kernel
On Thursday 21 May 2020 14:34:44 Pali Rohár wrote:
> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids provided by SD8997
> firmware.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 17 +++++++++++++++--
> drivers/net/wireless/marvell/mwifiex/fw.h | 2 ++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
Hello! Could you please look at this trivial patch?
> diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> index 7e4b8cd52..589cc5eb1 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> @@ -1581,8 +1581,21 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
> adapter->fw_api_ver =
> api_rev->major_ver;
> mwifiex_dbg(adapter, INFO,
> - "Firmware api version %d\n",
> - adapter->fw_api_ver);
> + "Firmware api version %d.%d\n",
> + adapter->fw_api_ver,
> + api_rev->minor_ver);
> + break;
> + case UAP_FW_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "uAP api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> + break;
> + case CHANRPT_API_VER_ID:
> + mwifiex_dbg(adapter, INFO,
> + "channel report api version %d.%d\n",
> + api_rev->major_ver,
> + api_rev->minor_ver);
> break;
> default:
> mwifiex_dbg(adapter, FATAL,
> diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
> index a415d73a7..6f86f5b96 100644
> --- a/drivers/net/wireless/marvell/mwifiex/fw.h
> +++ b/drivers/net/wireless/marvell/mwifiex/fw.h
> @@ -1052,6 +1052,8 @@ struct host_cmd_ds_802_11_ps_mode_enh {
> enum API_VER_ID {
> KEY_API_VER_ID = 1,
> FW_API_VER_ID = 2,
> + UAP_FW_API_VER_ID = 3,
> + CHANRPT_API_VER_ID = 4,
> };
>
> struct hw_spec_api_rev {
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] mwifiex: Parse all API_VER_ID properties
2020-05-28 10:28 ` Pali Rohár
@ 2020-05-29 3:47 ` Ganapathi Bhat
0 siblings, 0 replies; 4+ messages in thread
From: Ganapathi Bhat @ 2020-05-29 3:47 UTC (permalink / raw)
To: Pali Rohár, Amitkumar Karwar, Xinming Hu
Cc: Kalle Valo, David S. Miller, Marek Behún, linux-wireless,
netdev, linux-kernel
Hi Pali,
> Hello! Could you please look at this trivial patch?
The change look good.
Acked-by: Ganapathi Bhat <ganapathi.bhat@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mwifiex: Parse all API_VER_ID properties
2020-05-21 12:34 [PATCH] mwifiex: Parse all API_VER_ID properties Pali Rohár
2020-05-28 10:28 ` Pali Rohár
@ 2020-05-29 17:41 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-05-29 17:41 UTC (permalink / raw)
To: Pali Rohár
Cc: Amitkumar Karwar, Ganapathi Bhat, Xinming Hu, David S. Miller,
Marek Behún, linux-wireless, netdev, linux-kernel
Pali Rohár <pali@kernel.org> wrote:
> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids provided by SD8997
> firmware.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Acked-by: Ganapathi Bhat <ganapathi.bhat@nxp.com>
Patch applied to wireless-drivers-next.git, thanks.
86cffb2c0a59 mwifiex: Parse all API_VER_ID properties
--
https://patchwork.kernel.org/patch/11562833/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-29 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 12:34 [PATCH] mwifiex: Parse all API_VER_ID properties Pali Rohár
2020-05-28 10:28 ` Pali Rohár
2020-05-29 3:47 ` [EXT] " Ganapathi Bhat
2020-05-29 17:41 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).