* [PATCH 0/2] rtlwifi: Fix some Sparse warnings concerning endianess
@ 2020-06-04 0:57 Larry Finger
2020-06-04 0:57 ` [PATCH 1/2] rtlwifi: Fix endian issue in ps.c Larry Finger
2020-06-04 0:57 ` [PATCH 2/2] rtlwifi: rtl8188ee: Fix endian issue Larry Finger
0 siblings, 2 replies; 4+ messages in thread
From: Larry Finger @ 2020-06-04 0:57 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger
While investating an unrelated Sparse issue, some endian-related issues
were found in rtlwifi. Although it is unlikely that this hardware will
ever be mated to a big-endian host, the issues need to be corrected.
These issues do not cause incorrect code to be generated on little-endian
hosts, thus there is no urgency in their implementation.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger (2):
rtlwifi: Fix endian issue in ps.c
rtlwifi: rtl8188ee: Fix endian issue
drivers/net/wireless/realtek/rtlwifi/ps.c | 12 ++++++------
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] rtlwifi: Fix endian issue in ps.c
2020-06-04 0:57 [PATCH 0/2] rtlwifi: Fix some Sparse warnings concerning endianess Larry Finger
@ 2020-06-04 0:57 ` Larry Finger
2020-07-15 10:35 ` Kalle Valo
2020-06-04 0:57 ` [PATCH 2/2] rtlwifi: rtl8188ee: Fix endian issue Larry Finger
1 sibling, 1 reply; 4+ messages in thread
From: Larry Finger @ 2020-06-04 0:57 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger
Sparse reports the following endian issues:
CHECK drivers/net/wireless/realtek/rtlwifi/ps.c
drivers/net/wireless/realtek/rtlwifi/ps.c:772:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:772:42: warning: cast to restricted __le32
drivers/net/wireless/realtek/rtlwifi/ps.c:775:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:775:42: warning: cast to restricted __le32
drivers/net/wireless/realtek/rtlwifi/ps.c:778:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:778:42: warning: cast to restricted __le32
drivers/net/wireless/realtek/rtlwifi/ps.c:867:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:867:42: warning: cast to restricted __le32
drivers/net/wireless/realtek/rtlwifi/ps.c:870:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:870:42: warning: cast to restricted __le32
drivers/net/wireless/realtek/rtlwifi/ps.c:873:42: warning: restricted __le32 degrades to integer
drivers/net/wireless/realtek/rtlwifi/ps.c:873:42: warning: cast to restricted __le32
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtlwifi/ps.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
index bc0ac96ee615..90f92728e16a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/ps.c
+++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
@@ -769,13 +769,13 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void *data,
*(u8 *)(ie + index);
index += 1;
p2pinfo->noa_duration[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
p2pinfo->noa_interval[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
p2pinfo->noa_start_time[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
}
@@ -864,13 +864,13 @@ static void rtl_p2p_action_ie(struct ieee80211_hw *hw, void *data,
*(u8 *)(ie + index);
index += 1;
p2pinfo->noa_duration[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
p2pinfo->noa_interval[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
p2pinfo->noa_start_time[i] =
- le32_to_cpu(*(__le32 *)ie + index);
+ le32_to_cpu(*(__le32 *)(ie + index));
index += 4;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] rtlwifi: rtl8188ee: Fix endian issue
2020-06-04 0:57 [PATCH 0/2] rtlwifi: Fix some Sparse warnings concerning endianess Larry Finger
2020-06-04 0:57 ` [PATCH 1/2] rtlwifi: Fix endian issue in ps.c Larry Finger
@ 2020-06-04 0:57 ` Larry Finger
1 sibling, 0 replies; 4+ messages in thread
From: Larry Finger @ 2020-06-04 0:57 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger
Sparse reports the following issue:
CHECK drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:500:26: warning: incorrect type in initializer (different base types)
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:500:26: expected restricted __le32 [usertype] *pdesc
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:500:26: got unsigned int [usertype] *
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
index aa2e9e88be53..a5d2d6ece8db 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
@@ -497,7 +497,7 @@ void rtl88ee_tx_fill_desc(struct ieee80211_hw *hw,
dma_addr_t mapping;
u8 bw_40 = 0;
u8 short_gi = 0;
- __le32 *pdesc = (u32 *)pdesc8;
+ __le32 *pdesc = (__le32 *)pdesc8;
if (mac->opmode == NL80211_IFTYPE_STATION) {
bw_40 = mac->bw_40;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] rtlwifi: Fix endian issue in ps.c
2020-06-04 0:57 ` [PATCH 1/2] rtlwifi: Fix endian issue in ps.c Larry Finger
@ 2020-07-15 10:35 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-07-15 10:35 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Sparse reports the following endian issues:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/ps.c
> drivers/net/wireless/realtek/rtlwifi/ps.c:772:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:772:42: warning: cast to restricted __le32
> drivers/net/wireless/realtek/rtlwifi/ps.c:775:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:775:42: warning: cast to restricted __le32
> drivers/net/wireless/realtek/rtlwifi/ps.c:778:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:778:42: warning: cast to restricted __le32
> drivers/net/wireless/realtek/rtlwifi/ps.c:867:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:867:42: warning: cast to restricted __le32
> drivers/net/wireless/realtek/rtlwifi/ps.c:870:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:870:42: warning: cast to restricted __le32
> drivers/net/wireless/realtek/rtlwifi/ps.c:873:42: warning: restricted __le32 degrades to integer
> drivers/net/wireless/realtek/rtlwifi/ps.c:873:42: warning: cast to restricted __le32
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2 patches applied to wireless-drivers-next.git, thanks.
0df9edb37f3c rtlwifi: Fix endian issue in ps.c
97794e638cf5 rtlwifi: rtl8188ee: Fix endian issue
--
https://patchwork.kernel.org/patch/11586759/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 10:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 0:57 [PATCH 0/2] rtlwifi: Fix some Sparse warnings concerning endianess Larry Finger
2020-06-04 0:57 ` [PATCH 1/2] rtlwifi: Fix endian issue in ps.c Larry Finger
2020-07-15 10:35 ` Kalle Valo
2020-06-04 0:57 ` [PATCH 2/2] rtlwifi: rtl8188ee: Fix endian issue Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).