* [PATCH] ath9k: Do not select MAC80211_LEDS by default
@ 2020-08-20 19:40 Krzysztof Kozlowski
2020-08-27 10:18 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-20 19:40 UTC (permalink / raw)
To: QCA ath9k Development, Kalle Valo, David S. Miller,
Jakub Kicinski, linux-wireless, netdev, linux-kernel
Cc: Krzysztof Kozlowski
The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS
ifdefs so it does not really require the MAC80211_LEDS. The code builds
fine. Convert the "select" into "imply" to allow disabling LED trigger
when not needed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on HW.
Continuation of: https://lore.kernel.org/lkml/20200820120444.8809-1-krzk@kernel.org/
---
drivers/net/wireless/ath/ath9k/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig
index 5effb3886631..a84bb9b6573f 100644
--- a/drivers/net/wireless/ath/ath9k/Kconfig
+++ b/drivers/net/wireless/ath/ath9k/Kconfig
@@ -22,10 +22,10 @@ config ATH9K
tristate "Atheros 802.11n wireless cards support"
depends on MAC80211 && HAS_DMA
select ATH9K_HW
- select MAC80211_LEDS
- select LEDS_CLASS
- select NEW_LEDS
select ATH9K_COMMON
+ imply NEW_LEDS
+ imply LEDS_CLASS
+ imply MAC80211_LEDS
help
This module adds support for wireless adapters based on
Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath9k: Do not select MAC80211_LEDS by default
2020-08-20 19:40 [PATCH] ath9k: Do not select MAC80211_LEDS by default Krzysztof Kozlowski
@ 2020-08-27 10:18 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-08-27 10:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: QCA ath9k Development, David S. Miller, Jakub Kicinski,
linux-wireless, netdev, linux-kernel, Krzysztof Kozlowski
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS
> ifdefs so it does not really require the MAC80211_LEDS. The code builds
> fine. Convert the "select" into "imply" to allow disabling LED trigger
> when not needed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
72cdab808714 ath9k: Do not select MAC80211_LEDS by default
--
https://patchwork.kernel.org/patch/11727077/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-27 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 19:40 [PATCH] ath9k: Do not select MAC80211_LEDS by default Krzysztof Kozlowski
2020-08-27 10:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).