linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] atmel: Use fallthrough pseudo-keyword
@ 2020-08-21  6:53 Gustavo A. R. Silva
  2020-08-27 13:09 ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-08-21  6:53 UTC (permalink / raw)
  To: Kalle Valo, David S. Miller, Jakub Kicinski, Simon Kelley
  Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/wireless/atmel/at76c50x-usb.c | 2 +-
 drivers/net/wireless/atmel/atmel.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
index a63b5c2f1e17..b760c6682c4f 100644
--- a/drivers/net/wireless/atmel/at76c50x-usb.c
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -432,7 +432,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size,
 
 		case STATE_DFU_DOWNLOAD_IDLE:
 			at76_dbg(DBG_DFU, "DOWNLOAD...");
-			/* fall through */
+			fallthrough;
 		case STATE_DFU_IDLE:
 			at76_dbg(DBG_DFU, "DFU IDLE");
 
diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
index d5875836068c..6c97a1af5e8e 100644
--- a/drivers/net/wireless/atmel/atmel.c
+++ b/drivers/net/wireless/atmel/atmel.c
@@ -1227,7 +1227,7 @@ static irqreturn_t service_interrupt(int irq, void *dev_id)
 
 		case ISR_RxFRAMELOST:
 			priv->wstats.discard.misc++;
-			/* fall through */
+			fallthrough;
 		case ISR_RxCOMPLETE:
 			rx_done_irq(priv);
 			break;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword
  2020-08-21  6:53 [PATCH][next] atmel: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-08-27 13:09 ` Kalle Valo
  2020-08-27 19:38   ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2020-08-27 13:09 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: David S. Miller, Jakub Kicinski, Simon Kelley, linux-wireless,
	netdev, linux-kernel, Gustavo A. R. Silva

"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:

> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
> 
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Patch applied to wireless-drivers-next.git, thanks.

9ccac12996ec atmel: Use fallthrough pseudo-keyword

-- 
https://patchwork.kernel.org/patch/11728241/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][next] atmel: Use fallthrough pseudo-keyword
  2020-08-27 13:09 ` Kalle Valo
@ 2020-08-27 19:38   ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-08-27 19:38 UTC (permalink / raw)
  To: Kalle Valo
  Cc: David S. Miller, Jakub Kicinski, Simon Kelley, linux-wireless,
	netdev, linux-kernel

On Thu, Aug 27, 2020 at 01:09:33PM +0000, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> 
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> > 
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Patch applied to wireless-drivers-next.git, thanks.
> 

Thanks, Kalle.

--
Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-27 19:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21  6:53 [PATCH][next] atmel: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-08-27 13:09 ` Kalle Valo
2020-08-27 19:38   ` Gustavo A. R. Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).