* [PATCH] rtw88: fix compile warning: [-Wignored-qualifiers]
@ 2020-09-02 5:34 yhchuang
2020-09-07 8:30 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: yhchuang @ 2020-09-02 5:34 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, tehuang
From: Tzu-En Huang <tehuang@realtek.com>
Remove function return type const in rtw8821c_get_swing_index().
This is unused, and unnecessary to be const.
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw88/rtw8821c.c:71:8: warning: type
qualifiers ignored on function return type [-Wignored-qualifiers]
71 | static const u8 rtw8821c_get_swing_index(struct rtw_dev *rtwdev)
| ^~~~~
Fixes: f745eb9ca5bf ("rtw88: 8821c: Add 8821CE to Kconfig and Makefile")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Tzu-En Huang <tehuang@realtek.com>
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index d8863d8a5468..da2e7415be8f 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -68,7 +68,7 @@ static const u32 rtw8821c_txscale_tbl[] = {
0x2d3, 0x2fe, 0x32b, 0x35c, 0x38e, 0x3c4, 0x3fe
};
-static const u8 rtw8821c_get_swing_index(struct rtw_dev *rtwdev)
+static u8 rtw8821c_get_swing_index(struct rtw_dev *rtwdev)
{
u8 i = 0;
u32 swing, table_value;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtw88: fix compile warning: [-Wignored-qualifiers]
2020-09-02 5:34 [PATCH] rtw88: fix compile warning: [-Wignored-qualifiers] yhchuang
@ 2020-09-07 8:30 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-09-07 8:30 UTC (permalink / raw)
To: yhchuang; +Cc: linux-wireless, tehuang
<yhchuang@realtek.com> wrote:
> From: Tzu-En Huang <tehuang@realtek.com>
>
> Remove function return type const in rtw8821c_get_swing_index().
> This is unused, and unnecessary to be const.
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/net/wireless/realtek/rtw88/rtw8821c.c:71:8: warning: type
> qualifiers ignored on function return type [-Wignored-qualifiers]
> 71 | static const u8 rtw8821c_get_swing_index(struct rtw_dev *rtwdev)
> | ^~~~~
>
> Fixes: f745eb9ca5bf ("rtw88: 8821c: Add 8821CE to Kconfig and Makefile")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzu-En Huang <tehuang@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
8f8b8aa62e68 rtw88: fix compile warning: [-Wignored-qualifiers]
--
https://patchwork.kernel.org/patch/11749861/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 5:34 [PATCH] rtw88: fix compile warning: [-Wignored-qualifiers] yhchuang
2020-09-07 8:30 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).