linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Johannes Berg <johannes.berg@intel.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>,
	Intel Linux Wireless <linuxwifi@intel.com>
Subject: [PATCH 11/29] iwlwifi: dvm: scan: Demote a few nonconformant kernel-doc headers
Date: Thu, 10 Sep 2020 07:54:13 +0100	[thread overview]
Message-ID: <20200910065431.657636-12-lee.jones@linaro.org> (raw)
In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org>

2 of which do not attempt to document their parameters, 1 does a poor job.

Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:193: warning: Function parameter or member 'priv' not described in 'iwl_scan_cancel'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:205: warning: Function parameter or member 'priv' not described in 'iwl_scan_cancel_timeout'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'frame' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ta' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ies' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ie_len' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ssid' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ssid_len' not described in 'iwl_fill_probe_req'
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'left' not described in 'iwl_fill_probe_req'

Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
index 1d8590046ff7d..832fcbb787e98 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
@@ -186,7 +186,7 @@ static void iwl_do_scan_abort(struct iwl_priv *priv)
 		IWL_DEBUG_SCAN(priv, "Successfully send scan abort\n");
 }
 
-/**
+/*
  * iwl_scan_cancel - Cancel any currently executing HW scan
  */
 int iwl_scan_cancel(struct iwl_priv *priv)
@@ -196,10 +196,9 @@ int iwl_scan_cancel(struct iwl_priv *priv)
 	return 0;
 }
 
-/**
+/*
  * iwl_scan_cancel_timeout - Cancel any currently executing HW scan
  * @ms: amount of time to wait (in milliseconds) for scan to abort
- *
  */
 void iwl_scan_cancel_timeout(struct iwl_priv *priv, unsigned long ms)
 {
@@ -560,10 +559,9 @@ static int iwl_get_channels_for_scan(struct iwl_priv *priv,
 	return added;
 }
 
-/**
+/*
  * iwl_fill_probe_req - fill in all required fields and IE for probe request
  */
-
 static u16 iwl_fill_probe_req(struct ieee80211_mgmt *frame, const u8 *ta,
 			      const u8 *ies, int ie_len, const u8 *ssid,
 			      u8 ssid_len, int left)
-- 
2.25.1


  parent reply	other threads:[~2020-09-10  7:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  6:54 [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless Lee Jones
2020-09-10  6:54 ` [PATCH 01/29] iwlwifi: dvm: Demote non-compliant kernel-doc headers Lee Jones
2020-10-08 10:44   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 02/29] iwlwifi: rs: " Lee Jones
2020-09-10  6:54 ` [PATCH 03/29] iwlwifi: dvm: tx: " Lee Jones
2020-09-10  6:54 ` [PATCH 04/29] iwlwifi: dvm: lib: " Lee Jones
2020-09-10  6:54 ` [PATCH 05/29] iwlwifi: calib: Demote seemingly unintentional kerneldoc header Lee Jones
2020-09-10  6:54 ` [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' Lee Jones
2020-09-12  6:34   ` Kalle Valo
2020-09-15  9:17     ` Lee Jones
2020-09-10  6:54 ` [PATCH 07/29] iwlwifi: dvm: sta: Demote a bunch of nonconformant kernel-doc headers Lee Jones
2020-09-10  6:54 ` [PATCH 08/29] iwlwifi: mvm: ops: Remove unused static struct 'iwl_mvm_debug_names' Lee Jones
2020-09-10  6:54 ` [PATCH 09/29] iwlwifi: dvm: Demote a couple of nonconformant kernel-doc headers Lee Jones
2020-09-10  6:54 ` [PATCH 10/29] iwlwifi: mvm: utils: Fix some doc-rot Lee Jones
2020-09-10  6:54 ` Lee Jones [this message]
2020-09-10  6:54 ` [PATCH 12/29] iwlwifi: dvm: rxon: Demote non-conformant kernel-doc headers Lee Jones
2020-09-10  6:54 ` [PATCH 13/29] iwlwifi: mvm: tx: Demote misuse of " Lee Jones
2020-09-10  6:54 ` [PATCH 14/29] iwlwifi: dvm: devices: Fix function documentation formatting issues Lee Jones
2020-09-10  6:54 ` [PATCH 15/29] iwlwifi: iwl-drv: Provide descriptions debugfs dentries Lee Jones
2020-09-10  6:54 ` [PATCH 16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers Lee Jones
2020-09-10  6:54 ` [PATCH 17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc Lee Jones
2020-09-10  6:54 ` [PATCH 18/29] wil6210: txrx: Demote obvious abuse of kernel-doc Lee Jones
2020-09-10  6:54 ` [PATCH 19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc Lee Jones
2020-09-10  6:54 ` [PATCH 20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers Lee Jones
2020-09-10  6:54 ` [PATCH 21/29] wil6210: wil_platform: Demote kernel-doc header to standard comment block Lee Jones
2020-09-10  6:54 ` [PATCH 22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_' Lee Jones
2020-09-10  6:54 ` [PATCH 23/29] ath6kl: wmi: Remove unused variable 'rate' Lee Jones
2020-09-10 16:30   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 24/29] ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280' Lee Jones
2020-09-10 16:31   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 25/29] ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100' Lee Jones
2020-09-10 16:32   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 26/29] ath9k: ar5008_initvals: Remove unused table entirely Lee Jones
2020-09-10 16:33   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 27/29] ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used Lee Jones
2020-09-10 16:35   ` Kalle Valo
2020-09-10 16:47     ` Lee Jones
2020-09-10  6:54 ` [PATCH 28/29] brcmsmac: phytbl_lcn: Remove unused array 'dot11lcn_gain_tbl_rev1' Lee Jones
2020-09-16  5:58   ` Kalle Valo
2020-09-10  6:54 ` [PATCH 29/29] brcmsmac: phy_lcn: Remove unused variable 'lcnphy_rx_iqcomp_table_rev0' Lee Jones
2020-10-02  9:03 ` [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless Lee Jones
2020-10-06  5:49   ` Kalle Valo
2020-10-06  6:56     ` Lee Jones
2020-10-06  7:10       ` Kalle Valo
2020-10-07  6:01         ` Luca Coelho
2020-10-08  7:20           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910065431.657636-12-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=davem@davemloft.net \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luciano.coelho@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).