From: Lee Jones <lee.jones@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, wil6210@qti.qualcomm.com,
Maya Erez <merez@codeaurora.org>
Subject: Re: [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init'
Date: Tue, 15 Sep 2020 10:17:37 +0100 [thread overview]
Message-ID: <20200915091737.GC4678@dell> (raw)
In-Reply-To: <20200912063455.C3FA3C433CA@smtp.codeaurora.org>
On Sat, 12 Sep 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > Kerneldoc expects attributes/parameters to be in '@*.: ' format and
> > gets confused if the variable does not follow the type/attribute
> > definitions.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'wil' not described in 'wil6210_debugfs_init_offset'
> > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'dbg' not described in 'wil6210_debugfs_init_offset'
> > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'base' not described in 'wil6210_debugfs_init_offset'
> > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'tbl' not described in 'wil6210_debugfs_init_offset'
> >
> > Cc: Kalle Valo <kvalo@codeaurora.org>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: linux-wireless@vger.kernel.org
> > Cc: wil6210@qti.qualcomm.com
> > Cc: netdev@vger.kernel.org
> > Reviewed-by: Maya Erez <merez@codeaurora.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Aren't these also applied already? Please don't resend already applied
> patches.
Not at the time I rebased them.
> 8 patches set to Rejected.
>
> 11766845 [06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init'
> 11766747 [16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers
> 11766827 [17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc
> 11766825 [18/29] wil6210: txrx: Demote obvious abuse of kernel-doc
> 11766823 [19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc
> 11766821 [20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers
> 11766819 [21/29] wil6210: wil_platform: Demote kernel-doc header to standard comment block
> 11766817 [22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_'
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-09-15 9:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 6:54 [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless Lee Jones
2020-09-10 6:54 ` [PATCH 01/29] iwlwifi: dvm: Demote non-compliant kernel-doc headers Lee Jones
2020-10-08 10:44 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 02/29] iwlwifi: rs: " Lee Jones
2020-09-10 6:54 ` [PATCH 03/29] iwlwifi: dvm: tx: " Lee Jones
2020-09-10 6:54 ` [PATCH 04/29] iwlwifi: dvm: lib: " Lee Jones
2020-09-10 6:54 ` [PATCH 05/29] iwlwifi: calib: Demote seemingly unintentional kerneldoc header Lee Jones
2020-09-10 6:54 ` [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' Lee Jones
2020-09-12 6:34 ` Kalle Valo
2020-09-15 9:17 ` Lee Jones [this message]
2020-09-10 6:54 ` [PATCH 07/29] iwlwifi: dvm: sta: Demote a bunch of nonconformant kernel-doc headers Lee Jones
2020-09-10 6:54 ` [PATCH 08/29] iwlwifi: mvm: ops: Remove unused static struct 'iwl_mvm_debug_names' Lee Jones
2020-09-10 6:54 ` [PATCH 09/29] iwlwifi: dvm: Demote a couple of nonconformant kernel-doc headers Lee Jones
2020-09-10 6:54 ` [PATCH 10/29] iwlwifi: mvm: utils: Fix some doc-rot Lee Jones
2020-09-10 6:54 ` [PATCH 11/29] iwlwifi: dvm: scan: Demote a few nonconformant kernel-doc headers Lee Jones
2020-09-10 6:54 ` [PATCH 12/29] iwlwifi: dvm: rxon: Demote non-conformant " Lee Jones
2020-09-10 6:54 ` [PATCH 13/29] iwlwifi: mvm: tx: Demote misuse of " Lee Jones
2020-09-10 6:54 ` [PATCH 14/29] iwlwifi: dvm: devices: Fix function documentation formatting issues Lee Jones
2020-09-10 6:54 ` [PATCH 15/29] iwlwifi: iwl-drv: Provide descriptions debugfs dentries Lee Jones
2020-09-10 6:54 ` [PATCH 16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers Lee Jones
2020-09-10 6:54 ` [PATCH 17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc Lee Jones
2020-09-10 6:54 ` [PATCH 18/29] wil6210: txrx: Demote obvious abuse of kernel-doc Lee Jones
2020-09-10 6:54 ` [PATCH 19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc Lee Jones
2020-09-10 6:54 ` [PATCH 20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers Lee Jones
2020-09-10 6:54 ` [PATCH 21/29] wil6210: wil_platform: Demote kernel-doc header to standard comment block Lee Jones
2020-09-10 6:54 ` [PATCH 22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_' Lee Jones
2020-09-10 6:54 ` [PATCH 23/29] ath6kl: wmi: Remove unused variable 'rate' Lee Jones
2020-09-10 16:30 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 24/29] ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280' Lee Jones
2020-09-10 16:31 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 25/29] ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100' Lee Jones
2020-09-10 16:32 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 26/29] ath9k: ar5008_initvals: Remove unused table entirely Lee Jones
2020-09-10 16:33 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 27/29] ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used Lee Jones
2020-09-10 16:35 ` Kalle Valo
2020-09-10 16:47 ` Lee Jones
2020-09-10 6:54 ` [PATCH 28/29] brcmsmac: phytbl_lcn: Remove unused array 'dot11lcn_gain_tbl_rev1' Lee Jones
2020-09-16 5:58 ` Kalle Valo
2020-09-10 6:54 ` [PATCH 29/29] brcmsmac: phy_lcn: Remove unused variable 'lcnphy_rx_iqcomp_table_rev0' Lee Jones
2020-10-02 9:03 ` [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless Lee Jones
2020-10-06 5:49 ` Kalle Valo
2020-10-06 6:56 ` Lee Jones
2020-10-06 7:10 ` Kalle Valo
2020-10-07 6:01 ` Luca Coelho
2020-10-08 7:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915091737.GC4678@dell \
--to=lee.jones@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).