From: Kalle Valo <kvalo@codeaurora.org>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Marek Vasut <marex@denx.de>,
Angus Ainslie <angus@akkea.ca>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Martin Kepplinger <martink@posteo.de>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Siva Rebbagondla <siva8118@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP
Date: Sat, 7 Nov 2020 11:32:48 +0000 (UTC) [thread overview]
Message-ID: <20201107113248.A4EBEC433FE@smtp.codeaurora.org> (raw)
In-Reply-To: <20201015111616.429220-1-marex@denx.de>
Marek Vasut <marex@denx.de> wrote:
> In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode,
> the association fails. The former is using wpa_supplicant during association,
> the later is set up using hostapd:
>
> iwl$ cat hostapd.conf
> interface=wlp1s0
> ssid=test
> country_code=DE
> hw_mode=g
> channel=1
> wpa=2
> wpa_passphrase=test
> wpa_key_mgmt=WPA-PSK
> iwl$ hostapd -d hostapd.conf
>
> rsi$ wpa_supplicant -i wlan0 -c <(wpa_passphrase test test)
>
> The problem is that the TX EAPOL data descriptor RSI_DESC_REQUIRE_CFM_TO_HOST
> flag and extended descriptor EAPOL4_CONFIRM frame type are not set in case the
> AP is iwlwifi, because in that case the TX EAPOL packet is 2 bytes shorter.
>
> The downstream vendor driver has this change in place already [1], however
> there is no explanation for it, neither is there any commit history from which
> such explanation could be obtained.
>
> [1] https://github.com/SiliconLabs/RS911X-nLink-OSD/blob/master/rsi/rsi_91x_hal.c#L238
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Martin Kepplinger <martink@posteo.de>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Cc: Siva Rebbagondla <siva8118@gmail.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
Patch applied to wireless-drivers-next.git, thanks.
65277100caa2 rsi: Fix TX EAPOL packet handling against iwlwifi AP
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201015111616.429220-1-marex@denx.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-07 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 11:16 [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP Marek Vasut
2020-11-07 11:32 ` Kalle Valo [this message]
2021-05-27 16:52 ` Martin Fuzzey
2021-05-27 17:07 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107113248.A4EBEC433FE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=angus@akkea.ca \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marex@denx.de \
--cc=martink@posteo.de \
--cc=netdev@vger.kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).