[PATCH] rtw88: fix multiple definition of rtw_pm_ops

[PATCH] rtw88: fix multiple definition of rtw_pm_ops

[Ping-Ke Shih]

'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be
declare as 'extern' in pci.h. Without 'extern' causes every file including
pci.h has an individual instance of rtw_pm_ops but not reference to the one
declared in pci.c

If kernel config, like test robot, doesn't build driver as module, it leads
multiple definition.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2e86ef413ab3 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/pci.h b/drivers/net/wireless/realtek/rtw88/pci.h
index cda56919a5f0..7cdefe229824 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.h
+++ b/drivers/net/wireless/realtek/rtw88/pci.h
@@ -214,7 +214,7 @@ struct rtw_pci {
 	void __iomem *mmap;
 };
 
-const struct dev_pm_ops rtw_pm_ops;
+extern const struct dev_pm_ops rtw_pm_ops;
 
 int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
 void rtw_pci_remove(struct pci_dev *pdev);
-- 
2.21.0

Re: [PATCH] rtw88: fix multiple definition of rtw_pm_ops

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> 'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be
> declare as 'extern' in pci.h. Without 'extern' causes every file including
> pci.h has an individual instance of rtw_pm_ops but not reference to the one
> declared in pci.c
> 
> If kernel config, like test robot, doesn't build driver as module, it leads
> multiple definition.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 2e86ef413ab3 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown")
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

91aeaf09a6ee rtw88: fix multiple definition of rtw_pm_ops

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20201208013746.11065-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches