* [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
@ 2020-12-28 8:25 Ping-Ke Shih
2021-01-11 7:58 ` Kalle Valo
2021-01-14 17:26 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Ping-Ke Shih @ 2020-12-28 8:25 UTC (permalink / raw)
To: tony0620emma, kvalo; +Cc: linux-wireless, vincent_fann
From: vincent_fann <vincent_fann@realtek.com>
Hal function must follow the value that calculates from dynamic mechanism.
Force to set new_lvl to 4 damages receiving ability. System will not able
to reconnect to the AP if wifi unexpected disconnecting at this moment.
Signed-off-by: vincent_fann <vincent_fann@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index fbfd85439d1f..74155c999ebb 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1022,12 +1022,6 @@ static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
u8 pd[CCK_PD_LV_MAX] = {3, 7, 13, 13, 13};
u8 cck_n_rx;
- if (dm_info->min_rssi > 60) {
- new_lvl = 4;
- pd[4] = 0x1d;
- goto set_cck_pd;
- }
-
rtw_dbg(rtwdev, RTW_DBG_PHY, "lv: (%d) -> (%d)\n",
dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A], new_lvl);
@@ -1044,7 +1038,6 @@ static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl)
dm_info->cck_fa_avg = CCK_FA_AVG_RESET;
-set_cck_pd:
dm_info->cck_pd_lv[RTW_CHANNEL_WIDTH_20][RF_PATH_A] = new_lvl;
rtw_write32_mask(rtwdev, REG_PWRTH, 0x3f0000, pd[new_lvl]);
rtw_write32_mask(rtwdev, REG_PWRTH2, 0x1f0000,
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
2020-12-28 8:25 [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism Ping-Ke Shih
@ 2021-01-11 7:58 ` Kalle Valo
2021-01-12 2:16 ` Pkshih
2021-01-14 17:26 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2021-01-11 7:58 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: tony0620emma, linux-wireless, vincent_fann
Ping-Ke Shih <pkshih@realtek.com> writes:
> From: vincent_fann <vincent_fann@realtek.com>
>
> Hal function must follow the value that calculates from dynamic mechanism.
> Force to set new_lvl to 4 damages receiving ability. System will not able
> to reconnect to the AP if wifi unexpected disconnecting at this moment.
>
> Signed-off-by: vincent_fann <vincent_fann@realtek.com>
The real name looks to be just a copy of username, badly configured git
maybe? I can fix it during commit, how does Vincent format his name in
regular email? Does this look ok:
Vincent Fann <vincent_fann@realtek.com>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
2021-01-11 7:58 ` Kalle Valo
@ 2021-01-12 2:16 ` Pkshih
0 siblings, 0 replies; 4+ messages in thread
From: Pkshih @ 2021-01-12 2:16 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, tony0620emma, Vincent Fan
On Mon, 2021-01-11 at 07:58 +0000, Kalle Valo wrote:
> Ping-Ke Shih <pkshih@realtek.com> writes:
>
> > From: vincent_fann <vincent_fann@realtek.com>
> >
> > Hal function must follow the value that calculates from dynamic mechanism.
> > Force to set new_lvl to 4 damages receiving ability. System will not able
> > to reconnect to the AP if wifi unexpected disconnecting at this moment.
> >
> > Signed-off-by: vincent_fann <vincent_fann@realtek.com>
>
> The real name looks to be just a copy of username, badly configured git
> maybe? I can fix it during commit, how does Vincent format his name in
> regular email? Does this look ok:
>
> Vincent Fann <vincent_fann@realtek.com>
>
Yes, it does.
Please help to fix it.
Thank you
---
Ping-Ke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
2020-12-28 8:25 [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism Ping-Ke Shih
2021-01-11 7:58 ` Kalle Valo
@ 2021-01-14 17:26 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-01-14 17:26 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: tony0620emma, linux-wireless, vincent_fann
Ping-Ke Shih <pkshih@realtek.com> wrote:
> From: Vincent Fann <vincent_fann@realtek.com>
>
> Hal function must follow the value that calculates from dynamic mechanism.
> Force to set new_lvl to 4 damages receiving ability. System will not able
> to reconnect to the AP if wifi unexpected disconnecting at this moment.
>
> Signed-off-by: Vincent Fann <vincent_fann@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
840105e4f12f rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201228082516.16488-1-pkshih@realtek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-14 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 8:25 [PATCH] rtw88: 8821c: apply CCK PD level which calculates from dynamic mechanism Ping-Ke Shih
2021-01-11 7:58 ` Kalle Valo
2021-01-12 2:16 ` Pkshih
2021-01-14 17:26 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).