* [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
@ 2021-02-18 7:20 Jiapeng Chong
2021-02-18 8:13 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Jiapeng Chong @ 2021-02-18 7:20 UTC (permalink / raw)
To: stf_xl
Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
|| A && B is equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 28675a4..52db532 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
*/
if (ret != IL_INVALID_STATION &&
(!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
- ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
- (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
+ (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
IL_ERR("Requested station info for sta %d before ready.\n",
ret);
ret = IL_INVALID_STATION;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
2021-02-18 7:20 [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables Jiapeng Chong
@ 2021-02-18 8:13 ` Stanislaw Gruszka
0 siblings, 0 replies; 5+ messages in thread
From: Stanislaw Gruszka @ 2021-02-18 8:13 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
On Thu, Feb 18, 2021 at 03:20:14PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> index 28675a4..52db532 100644
> --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
> @@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
> */
> if (ret != IL_INVALID_STATION &&
> (!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
> - ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
> - (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
> + (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
> IL_ERR("Requested station info for sta %d before ready.\n",
> ret);
> ret = IL_INVALID_STATION;
This patch was already applied to wireless-drivers-next.
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
2021-02-04 8:00 Jiapeng Chong
2021-02-04 9:14 ` Stanislaw Gruszka
@ 2021-02-08 11:21 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-02-08 11:21 UTC (permalink / raw)
To: Jiapeng Chong
Cc: stf_xl, davem, kuba, linux-wireless, netdev, linux-kernel, Jiapeng Chong
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
fcb8f3ca4b5b iwlegacy: 4965-mac: Simplify the calculation of variables
--
https://patchwork.kernel.org/project/linux-wireless/patch/1612425608-40450-1-git-send-email-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
2021-02-04 8:00 Jiapeng Chong
@ 2021-02-04 9:14 ` Stanislaw Gruszka
2021-02-08 11:21 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Stanislaw Gruszka @ 2021-02-04 9:14 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
On Thu, Feb 04, 2021 at 04:00:08PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
> || A && B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables
@ 2021-02-04 8:00 Jiapeng Chong
2021-02-04 9:14 ` Stanislaw Gruszka
2021-02-08 11:21 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Jiapeng Chong @ 2021-02-04 8:00 UTC (permalink / raw)
To: stf_xl
Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A
|| A && B is equivalent to !A || B.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 28675a4..52db532 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -2593,8 +2593,7 @@ struct il_mod_params il4965_mod_params = {
*/
if (ret != IL_INVALID_STATION &&
(!(il->stations[ret].used & IL_STA_UCODE_ACTIVE) ||
- ((il->stations[ret].used & IL_STA_UCODE_ACTIVE) &&
- (il->stations[ret].used & IL_STA_UCODE_INPROGRESS)))) {
+ (il->stations[ret].used & IL_STA_UCODE_INPROGRESS))) {
IL_ERR("Requested station info for sta %d before ready.\n",
ret);
ret = IL_INVALID_STATION;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-18 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 7:20 [PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables Jiapeng Chong
2021-02-18 8:13 ` Stanislaw Gruszka
-- strict thread matches above, loose matches on Subject: below --
2021-02-04 8:00 Jiapeng Chong
2021-02-04 9:14 ` Stanislaw Gruszka
2021-02-08 11:21 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).