* [PATCH -next] iwlwifi: mvm: fix old-style static const declaration
@ 2021-03-04 10:22 'Wei Yongjun
2021-03-23 8:02 ` Coelho, Luciano
0 siblings, 1 reply; 2+ messages in thread
From: 'Wei Yongjun @ 2021-03-04 10:22 UTC (permalink / raw)
To: weiyongjun1, Luca Coelho, Kalle Valo, Jakub Kicinski, Gregory Greenman
Cc: linux-wireless, netdev, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
GCC reports warning as follows:
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
'static' is not at beginning of declaration [-Wold-style-declaration]
14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
| ^~~~~
Move static to the beginning of declaration.
Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@
* DDR needs frequency in units of 16.666MHz, so provide FW with the
* frequency values in the adjusted format.
*/
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
/* LPDDR4 */
/* frequency 3733MHz */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] iwlwifi: mvm: fix old-style static const declaration
2021-03-04 10:22 [PATCH -next] iwlwifi: mvm: fix old-style static const declaration 'Wei Yongjun
@ 2021-03-23 8:02 ` Coelho, Luciano
0 siblings, 0 replies; 2+ messages in thread
From: Coelho, Luciano @ 2021-03-23 8:02 UTC (permalink / raw)
To: weiyongjun1, Greenman, Gregory, kvalo, kuba
Cc: linux-wireless, hulkci, netdev
On Thu, 2021-03-04 at 10:22 +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> GCC reports warning as follows:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
> 'static' is not at beginning of declaration [-Wold-style-declaration]
> 14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
> | ^~~~~
>
> Move static to the beginning of declaration.
>
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Thanks, I applied this to our internal tree and it will reach the
mainline following our usual process.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 10:22 [PATCH -next] iwlwifi: mvm: fix old-style static const declaration 'Wei Yongjun
2021-03-23 8:02 ` Coelho, Luciano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).