* [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue
@ 2021-03-13 14:36 Hans de Goede
2021-03-13 15:22 ` Johannes Berg
2021-03-23 9:37 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2021-03-13 14:36 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo,
Chi-Hsien Lin, Chung-hsien Hsu, Wright Feng
Cc: Hans de Goede, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list, Johannes Berg
Commit a05829a7222e ("cfg80211: avoid holding the RTNL when calling the
driver") replaced the rtnl_lock parameter passed to various brcmf
functions with just lock, because since that commit it is not just
about the rtnl_lock but also about the wiphy_lock .
During this search/replace the "if (!rtnl_locked)" check in brcmfmac/p2p.c
was accidentally replaced with "if (locked)", dropping the inversion of
the check. This causes the code to now call rtnl_lock() while already
holding the lock, causing a deadlock.
Add back the "!" to the if-condition to fix this.
Cc: Johannes Berg <johannes.berg@intel.com>
Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 6d30a0fcecea..34cd8a7401fe 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2439,7 +2439,7 @@ void brcmf_p2p_ifp_removed(struct brcmf_if *ifp, bool locked)
vif = ifp->vif;
cfg = wdev_to_cfg(&vif->wdev);
cfg->p2p.bss_idx[P2PAPI_BSSCFG_DEVICE].vif = NULL;
- if (locked) {
+ if (!locked) {
rtnl_lock();
wiphy_lock(cfg->wiphy);
cfg80211_unregister_wdev(&vif->wdev);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue
2021-03-13 14:36 [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue Hans de Goede
@ 2021-03-13 15:22 ` Johannes Berg
2021-03-23 9:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2021-03-13 15:22 UTC (permalink / raw)
To: Hans de Goede, Arend van Spriel, Franky Lin, Hante Meuleman,
Kalle Valo, Chi-Hsien Lin, Chung-hsien Hsu, Wright Feng
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
On Sat, 2021-03-13 at 15:36 +0100, Hans de Goede wrote:
> Commit a05829a7222e ("cfg80211: avoid holding the RTNL when calling the
> driver") replaced the rtnl_lock parameter passed to various brcmf
> functions with just lock, because since that commit it is not just
> about the rtnl_lock but also about the wiphy_lock .
>
> During this search/replace the "if (!rtnl_locked)" check in brcmfmac/p2p.c
> was accidentally replaced with "if (locked)", dropping the inversion of
> the check. This causes the code to now call rtnl_lock() while already
> holding the lock, causing a deadlock.
>
> Add back the "!" to the if-condition to fix this.
Ouch, sorry about that, and thanks for the fix!
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue
2021-03-13 14:36 [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue Hans de Goede
2021-03-13 15:22 ` Johannes Berg
@ 2021-03-23 9:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-03-23 9:37 UTC (permalink / raw)
To: Hans de Goede
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Chung-hsien Hsu, Wright Feng, Hans de Goede, linux-wireless,
brcm80211-dev-list.pdl, SHA-cyfmac-dev-list, Johannes Berg
Hans de Goede <hdegoede@redhat.com> wrote:
> Commit a05829a7222e ("cfg80211: avoid holding the RTNL when calling the
> driver") replaced the rtnl_lock parameter passed to various brcmf
> functions with just lock, because since that commit it is not just
> about the rtnl_lock but also about the wiphy_lock .
>
> During this search/replace the "if (!rtnl_locked)" check in brcmfmac/p2p.c
> was accidentally replaced with "if (locked)", dropping the inversion of
> the check. This causes the code to now call rtnl_lock() while already
> holding the lock, causing a deadlock.
>
> Add back the "!" to the if-condition to fix this.
>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Patch applied to wireless-drivers.git, thanks.
bd83a2fc05ed brcmfmac: p2p: Fix recently introduced deadlock issue
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210313143635.109154-1-hdegoede@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 14:36 [PATCH 5.12 regression fix] brcmfmac: p2p: Fix recently introduced deadlock issue Hans de Goede
2021-03-13 15:22 ` Johannes Berg
2021-03-23 9:37 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).