linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] virt_wifi: Return micros for BSS TSF values
@ 2021-03-18  2:01 A. Cody Schuffelen
  2021-03-18 13:19 ` kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: A. Cody Schuffelen @ 2021-03-18  2:01 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless, netdev, linux-kernel, A. Cody Schuffelen

cfg80211_inform_bss expects to receive a TSF value, but is given the
time since boot in nanoseconds. TSF values are expected to be at
microsecond scale rather than nanosecond scale.

Signed-off-by: A. Cody Schuffelen <schuffelen@google.com>
---
 drivers/net/wireless/virt_wifi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index c878097f0dda..07cefd0a86be 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -172,7 +172,7 @@ static void virt_wifi_scan_result(struct work_struct *work)
 	informed_bss = cfg80211_inform_bss(wiphy, &channel_5ghz,
 					   CFG80211_BSS_FTYPE_PRESP,
 					   fake_router_bssid,
-					   ktime_get_boottime_ns(),
+					   ktime_get_boottime_ns() / 1000,
 					   WLAN_CAPABILITY_ESS, 0,
 					   (void *)&ssid, sizeof(ssid),
 					   DBM_TO_MBM(-50), GFP_KERNEL);
-- 
2.31.0.rc2.261.g7f71774620-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] virt_wifi: Return micros for BSS TSF values
  2021-03-18  2:01 [PATCH] virt_wifi: Return micros for BSS TSF values A. Cody Schuffelen
@ 2021-03-18 13:19 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-03-18 13:19 UTC (permalink / raw)
  To: A. Cody Schuffelen, Johannes Berg
  Cc: kbuild-all, linux-wireless, netdev, linux-kernel, A. Cody Schuffelen

[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]

Hi Cody,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master ipvs/master v5.12-rc3 next-20210317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/A-Cody-Schuffelen/virt_wifi-Return-micros-for-BSS-TSF-values/20210318-100417
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6c3f5b51c512d7947ccef9ef5e6a1ee352b77b63
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review A-Cody-Schuffelen/virt_wifi-Return-micros-for-BSS-TSF-values/20210318-100417
        git checkout 6c3f5b51c512d7947ccef9ef5e6a1ee352b77b63
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: drivers/net/wireless/virt_wifi.o: in function `virt_wifi_scan_result':
>> virt_wifi.c:(.text+0xac8): undefined reference to `__aeabi_uldivmod'

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77915 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-18 13:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18  2:01 [PATCH] virt_wifi: Return micros for BSS TSF values A. Cody Schuffelen
2021-03-18 13:19 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).