* [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting
@ 2021-03-09 10:09 Lorenzo Bianconi
2021-03-09 10:28 ` Kalle Valo
2021-03-23 9:36 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Lorenzo Bianconi @ 2021-03-09 10:09 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, lorenzo.bianconi, nbd, sean.wang, leon.yen
Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
trigger a tx hangs before resetting airtime stats.
Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
Tested-by: Leon Yen <leon.yen@mediatek.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/wireless/mediatek/mt76/mt7921/regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
index 18980bb32dee..6dad7f6ab09d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
@@ -135,10 +135,10 @@
#define MT_WTBLON_TOP_BASE 0x34000
#define MT_WTBLON_TOP(ofs) (MT_WTBLON_TOP_BASE + (ofs))
-#define MT_WTBLON_TOP_WDUCR MT_WTBLON_TOP(0x0)
+#define MT_WTBLON_TOP_WDUCR MT_WTBLON_TOP(0x200)
#define MT_WTBLON_TOP_WDUCR_GROUP GENMASK(2, 0)
-#define MT_WTBL_UPDATE MT_WTBLON_TOP(0x030)
+#define MT_WTBL_UPDATE MT_WTBLON_TOP(0x230)
#define MT_WTBL_UPDATE_WLAN_IDX GENMASK(9, 0)
#define MT_WTBL_UPDATE_ADM_COUNT_CLEAR BIT(12)
#define MT_WTBL_UPDATE_BUSY BIT(31)
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting
2021-03-09 10:09 [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting Lorenzo Bianconi
@ 2021-03-09 10:28 ` Kalle Valo
2021-03-09 12:54 ` Felix Fietkau
2021-03-23 9:36 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2021-03-09 10:28 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: linux-wireless, lorenzo.bianconi, nbd, sean.wang, leon.yen
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
> trigger a tx hangs before resetting airtime stats.
>
> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
> Tested-by: Leon Yen <leon.yen@mediatek.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
I'll queue this to v5.12 and assigned to me on patchwork. Felix, ack?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting
2021-03-09 10:28 ` Kalle Valo
@ 2021-03-09 12:54 ` Felix Fietkau
0 siblings, 0 replies; 4+ messages in thread
From: Felix Fietkau @ 2021-03-09 12:54 UTC (permalink / raw)
To: Kalle Valo
Cc: Lorenzo Bianconi, linux-wireless, lorenzo.bianconi, sean.wang, leon.yen
> On 9. Mar 2021, at 11:29, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>
>> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
>> trigger a tx hangs before resetting airtime stats.
>>
>> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
>> Tested-by: Leon Yen <leon.yen@mediatek.com>
>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> I'll queue this to v5.12 and assigned to me on patchwork. Felix, ack?
Acked-by: Felix Fietkau <nbd@nbd.name>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting
2021-03-09 10:09 [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting Lorenzo Bianconi
2021-03-09 10:28 ` Kalle Valo
@ 2021-03-23 9:36 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-03-23 9:36 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: linux-wireless, lorenzo.bianconi, nbd, sean.wang, leon.yen
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
> trigger a tx hangs before resetting airtime stats.
>
> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
> Tested-by: Leon Yen <leon.yen@mediatek.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers.git, thanks.
8f6a70fd71a3 mt76: mt7921: fix airtime reporting
--
https://patchwork.kernel.org/project/linux-wireless/patch/c05333be0e3e85a50a71bb2de81034fe425e3701.1615284335.git.lorenzo@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-23 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 10:09 [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting Lorenzo Bianconi
2021-03-09 10:28 ` Kalle Valo
2021-03-09 12:54 ` Felix Fietkau
2021-03-23 9:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).