* [PATCH] wil6210: wmi: Remove useless code
@ 2021-04-07 9:46 Jiapeng Chong
2021-04-18 6:36 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-07 9:46 UTC (permalink / raw)
To: merez
Cc: kvalo, davem, kuba, linux-wireless, wil6210, netdev,
linux-kernel, Jiapeng Chong
Fix the following whitescan warning:
An unsigned value can never be less than 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/ath/wil6210/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index 823ec6e..02ad449 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -1456,7 +1456,7 @@ static void wil_link_stats_store_basic(struct wil6210_vif *vif,
u8 cid = basic->cid;
struct wil_sta_info *sta;
- if (cid < 0 || cid >= wil->max_assoc_sta) {
+ if (cid >= wil->max_assoc_sta) {
wil_err(wil, "invalid cid %d\n", cid);
return;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wil6210: wmi: Remove useless code
2021-04-07 9:46 [PATCH] wil6210: wmi: Remove useless code Jiapeng Chong
@ 2021-04-18 6:36 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-04-18 6:36 UTC (permalink / raw)
To: Jiapeng Chong
Cc: merez, davem, kuba, linux-wireless, wil6210, netdev,
linux-kernel, Jiapeng Chong
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Fix the following whitescan warning:
>
> An unsigned value can never be less than 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Patch applied to wireless-drivers-next.git, thanks.
5e6087559e85 wil6210: wmi: Remove useless code
--
https://patchwork.kernel.org/project/linux-wireless/patch/1617788766-91433-1-git-send-email-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-18 6:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 9:46 [PATCH] wil6210: wmi: Remove useless code Jiapeng Chong
2021-04-18 6:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).