* [PATCH v2] ath9k_htc: Add a missing spin_lock_init()
[not found] <38fa8cc-c9c4-66c1-e2ee-fe02caa7ef63@gmail.com>
@ 2021-07-28 19:17 ` Rajat Asthana
2021-07-28 19:37 ` Rajat Asthana
0 siblings, 1 reply; 5+ messages in thread
From: Rajat Asthana @ 2021-07-28 19:17 UTC (permalink / raw)
To: ath9k-devel, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: Rajat Asthana
Syzkaller reported a lockdep warning on non-initialized spinlock:
INFO: trying to register non-static key.
The code is fine but needs lockdep annotation, or maybe
you didn't initialize this object before use?
turning off the locking correctness validator.
CPU: 0 PID: 10 Comm: ksoftirqd/0 Not tainted 5.13.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x143/0x1db lib/dump_stack.c:120
assign_lock_key kernel/locking/lockdep.c:937 [inline]
register_lock_class+0x1077/0x1180 kernel/locking/lockdep.c:1249
__lock_acquire+0x102/0x5230 kernel/locking/lockdep.c:4781
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x19d/0x700 kernel/locking/lockdep.c:5477
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
spin_lock_bh include/linux/spinlock.h:359 [inline]
ath9k_wmi_event_tasklet+0x231/0x3f0 drivers/net/wireless/ath/ath9k/wmi.c:172
tasklet_action_common.constprop.0+0x201/0x2e0 kernel/softirq.c:784
__do_softirq+0x1b0/0x944 kernel/softirq.c:559
run_ksoftirqd kernel/softirq.c:921 [inline]
run_ksoftirqd+0x21/0x50 kernel/softirq.c:913
smpboot_thread_fn+0x3ec/0x870 kernel/smpboot.c:165
kthread+0x38c/0x460 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
We missed a spin_lock_init() in ath9k_wmi_event_tasklet() when the wmi
event is WMI_TXSTATUS_EVENTID. So, add a spin_lock_init() in
ath9k_init_wmi().
Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
---
drivers/net/wireless/ath/ath9k/wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c
index fe29ad4b9023..480de2170816 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.c
+++ b/drivers/net/wireless/ath/ath9k/wmi.c
@@ -101,6 +101,7 @@ struct wmi *ath9k_init_wmi(struct ath9k_htc_priv *priv)
skb_queue_head_init(&wmi->wmi_event_queue);
spin_lock_init(&wmi->wmi_lock);
spin_lock_init(&wmi->event_lock);
+ spin_lock_init(&wmi->drv_priv->tx.tx_lock);
mutex_init(&wmi->op_mutex);
mutex_init(&wmi->multi_write_mutex);
mutex_init(&wmi->multi_rmw_mutex);
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ath9k_htc: Add a missing spin_lock_init()
2021-07-28 19:17 ` [PATCH v2] ath9k_htc: Add a missing spin_lock_init() Rajat Asthana
@ 2021-07-28 19:37 ` Rajat Asthana
0 siblings, 0 replies; 5+ messages in thread
From: Rajat Asthana @ 2021-07-28 19:37 UTC (permalink / raw)
To: ath9k-devel, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
please ignore this patch!
I have sent this by wrongly giving the `in-reply-to` field in the `git
send-email`. Really sorry for this!
Best wishes,
-- Rajat
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ath9k_htc: Add a missing spin_lock_init()
2021-07-28 19:25 ` [PATCH v2] " Rajat Asthana
2021-07-29 7:41 ` Kalle Valo
@ 2021-12-20 15:50 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-12-20 15:50 UTC (permalink / raw)
To: Rajat Asthana
Cc: ath9k-devel, kvalo, davem, kuba, linux-wireless, netdev,
linux-kernel, Rajat Asthana
Rajat Asthana <rajatasthana4@gmail.com> wrote:
> Syzkaller reported a lockdep warning on non-initialized spinlock:
>
> INFO: trying to register non-static key.
> The code is fine but needs lockdep annotation, or maybe
> you didn't initialize this object before use?
> turning off the locking correctness validator.
> CPU: 0 PID: 10 Comm: ksoftirqd/0 Not tainted 5.13.0-rc4-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Call Trace:
> __dump_stack lib/dump_stack.c:79 [inline]
> dump_stack+0x143/0x1db lib/dump_stack.c:120
> assign_lock_key kernel/locking/lockdep.c:937 [inline]
> register_lock_class+0x1077/0x1180 kernel/locking/lockdep.c:1249
> __lock_acquire+0x102/0x5230 kernel/locking/lockdep.c:4781
> lock_acquire kernel/locking/lockdep.c:5512 [inline]
> lock_acquire+0x19d/0x700 kernel/locking/lockdep.c:5477
> __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
> _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
> spin_lock_bh include/linux/spinlock.h:359 [inline]
> ath9k_wmi_event_tasklet+0x231/0x3f0 drivers/net/wireless/ath/ath9k/wmi.c:172
> tasklet_action_common.constprop.0+0x201/0x2e0 kernel/softirq.c:784
> __do_softirq+0x1b0/0x944 kernel/softirq.c:559
> run_ksoftirqd kernel/softirq.c:921 [inline]
> run_ksoftirqd+0x21/0x50 kernel/softirq.c:913
> smpboot_thread_fn+0x3ec/0x870 kernel/smpboot.c:165
> kthread+0x38c/0x460 kernel/kthread.c:313
> ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
>
> We missed a spin_lock_init() in ath9k_wmi_event_tasklet() when the wmi
> event is WMI_TXSTATUS_EVENTID. So, add a spin_lock_init() in
> ath9k_init_wmi().
>
> Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
The lock is already initialised in ath9k_init_priv(), so now the same lock is
initialised twice. ath9k_init_wmi() is called before ath9k_init_priv(), so it
looks like we have a race somewhere.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210728192533.18727-1-rajatasthana4@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ath9k_htc: Add a missing spin_lock_init()
2021-07-28 19:25 ` [PATCH v2] " Rajat Asthana
@ 2021-07-29 7:41 ` Kalle Valo
2021-12-20 15:50 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-07-29 7:41 UTC (permalink / raw)
To: Rajat Asthana
Cc: ath9k-devel, davem, kuba, linux-wireless, netdev, linux-kernel
Rajat Asthana <rajatasthana4@gmail.com> writes:
> Syzkaller reported a lockdep warning on non-initialized spinlock:
>
> INFO: trying to register non-static key.
> The code is fine but needs lockdep annotation, or maybe
> you didn't initialize this object before use?
> turning off the locking correctness validator.
> CPU: 0 PID: 10 Comm: ksoftirqd/0 Not tainted 5.13.0-rc4-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Call Trace:
> __dump_stack lib/dump_stack.c:79 [inline]
> dump_stack+0x143/0x1db lib/dump_stack.c:120
> assign_lock_key kernel/locking/lockdep.c:937 [inline]
> register_lock_class+0x1077/0x1180 kernel/locking/lockdep.c:1249
> __lock_acquire+0x102/0x5230 kernel/locking/lockdep.c:4781
> lock_acquire kernel/locking/lockdep.c:5512 [inline]
> lock_acquire+0x19d/0x700 kernel/locking/lockdep.c:5477
> __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
> _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
> spin_lock_bh include/linux/spinlock.h:359 [inline]
> ath9k_wmi_event_tasklet+0x231/0x3f0 drivers/net/wireless/ath/ath9k/wmi.c:172
> tasklet_action_common.constprop.0+0x201/0x2e0 kernel/softirq.c:784
> __do_softirq+0x1b0/0x944 kernel/softirq.c:559
> run_ksoftirqd kernel/softirq.c:921 [inline]
> run_ksoftirqd+0x21/0x50 kernel/softirq.c:913
> smpboot_thread_fn+0x3ec/0x870 kernel/smpboot.c:165
> kthread+0x38c/0x460 kernel/kthread.c:313
> ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
>
> We missed a spin_lock_init() in ath9k_wmi_event_tasklet() when the wmi
> event is WMI_TXSTATUS_EVENTID. So, add a spin_lock_init() in
> ath9k_init_wmi().
>
> Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
I assume this version is also not tested on a real device. Can someone
review and/or test this, please?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ath9k_htc: Add a missing spin_lock_init()
2021-07-28 19:02 [PATCH] " Rajat Asthana
@ 2021-07-28 19:25 ` Rajat Asthana
2021-07-29 7:41 ` Kalle Valo
2021-12-20 15:50 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Rajat Asthana @ 2021-07-28 19:25 UTC (permalink / raw)
To: ath9k-devel, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
Cc: Rajat Asthana
Syzkaller reported a lockdep warning on non-initialized spinlock:
INFO: trying to register non-static key.
The code is fine but needs lockdep annotation, or maybe
you didn't initialize this object before use?
turning off the locking correctness validator.
CPU: 0 PID: 10 Comm: ksoftirqd/0 Not tainted 5.13.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x143/0x1db lib/dump_stack.c:120
assign_lock_key kernel/locking/lockdep.c:937 [inline]
register_lock_class+0x1077/0x1180 kernel/locking/lockdep.c:1249
__lock_acquire+0x102/0x5230 kernel/locking/lockdep.c:4781
lock_acquire kernel/locking/lockdep.c:5512 [inline]
lock_acquire+0x19d/0x700 kernel/locking/lockdep.c:5477
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:175
spin_lock_bh include/linux/spinlock.h:359 [inline]
ath9k_wmi_event_tasklet+0x231/0x3f0 drivers/net/wireless/ath/ath9k/wmi.c:172
tasklet_action_common.constprop.0+0x201/0x2e0 kernel/softirq.c:784
__do_softirq+0x1b0/0x944 kernel/softirq.c:559
run_ksoftirqd kernel/softirq.c:921 [inline]
run_ksoftirqd+0x21/0x50 kernel/softirq.c:913
smpboot_thread_fn+0x3ec/0x870 kernel/smpboot.c:165
kthread+0x38c/0x460 kernel/kthread.c:313
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
We missed a spin_lock_init() in ath9k_wmi_event_tasklet() when the wmi
event is WMI_TXSTATUS_EVENTID. So, add a spin_lock_init() in
ath9k_init_wmi().
Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
---
drivers/net/wireless/ath/ath9k/wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath9k/wmi.c b/drivers/net/wireless/ath/ath9k/wmi.c
index fe29ad4b9023..480de2170816 100644
--- a/drivers/net/wireless/ath/ath9k/wmi.c
+++ b/drivers/net/wireless/ath/ath9k/wmi.c
@@ -101,6 +101,7 @@ struct wmi *ath9k_init_wmi(struct ath9k_htc_priv *priv)
skb_queue_head_init(&wmi->wmi_event_queue);
spin_lock_init(&wmi->wmi_lock);
spin_lock_init(&wmi->event_lock);
+ spin_lock_init(&wmi->drv_priv->tx.tx_lock);
mutex_init(&wmi->op_mutex);
mutex_init(&wmi->multi_write_mutex);
mutex_init(&wmi->multi_rmw_mutex);
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-20 15:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <38fa8cc-c9c4-66c1-e2ee-fe02caa7ef63@gmail.com>
2021-07-28 19:17 ` [PATCH v2] ath9k_htc: Add a missing spin_lock_init() Rajat Asthana
2021-07-28 19:37 ` Rajat Asthana
2021-07-28 19:02 [PATCH] " Rajat Asthana
2021-07-28 19:25 ` [PATCH v2] " Rajat Asthana
2021-07-29 7:41 ` Kalle Valo
2021-12-20 15:50 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).