From: Colin King <colin.king@canonical.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] rtlwifi: rtl8192de: fix array size limit in for-loop
Date: Tue, 3 Aug 2021 15:49:49 +0100 [thread overview]
Message-ID: <20210803144949.79433-3-colin.king@canonical.com> (raw)
In-Reply-To: <20210803144949.79433-1-colin.king@canonical.com>
From: Colin Ian King <colin.king@canonical.com>
Currently the size of the entire array is being used in a for-loop
for the element count. While this works since the elements are u8
sized, it is preferred to use ARRAY_SIZE to get the element count
of the array.
Kudos to Joe Perches for spotting this issue.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index 8ae69d914312..e11728622a9e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -1366,7 +1366,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
u8 place = chnl;
if (chnl > 14) {
- for (place = 14; place < sizeof(channel_all); place++) {
+ for (place = 14; place < ARRAY_SIZE(channel_all); place++) {
if (channel_all[place] == chnl)
return place - 13;
}
--
2.31.1
next prev parent reply other threads:[~2021-08-03 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 14:49 [PATCH 1/3][RESEND] rtlwifi: rtl8192de: Remove redundant variable initializations Colin King
2021-08-03 14:49 ` [PATCH 2/3][V2] rtlwifi: rtl8192de: make arrays static const, makes object smaller Colin King
2021-08-03 15:09 ` Joe Perches
2021-08-03 15:15 ` Colin Ian King
2021-08-03 15:23 ` Joe Perches
2021-08-03 14:49 ` Colin King [this message]
2021-08-03 18:11 ` [PATCH 3/3] rtlwifi: rtl8192de: fix array size limit in for-loop Joe Perches
2021-08-03 18:12 ` Colin Ian King
2021-08-21 17:31 ` Kalle Valo
2021-08-21 17:33 ` [PATCH 1/3][RESEND] rtlwifi: rtl8192de: Remove redundant variable initializations Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803144949.79433-3-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).