* [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c
@ 2021-08-21 2:09 Randy Dunlap
2021-09-05 19:07 ` Randy Dunlap
2021-09-06 10:03 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-08-21 2:09 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, kernel test robot, Kalle Valo, Luca Coelho,
linux-wireless, David S. Miller, Jakub Kicinski
The kernel test robot reports printk format warnings in uefi.c, so
correct them.
../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
52 | "PNVM UEFI variable not found %d (len %zd)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
53 | err, package_size);
| ~~~~~~~~~~~~
| |
| long unsigned int
../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
59 | IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
| |
| long unsigned int
Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20210820.orig/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
+++ linux-next-20210820/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
@@ -49,14 +49,14 @@ void *iwl_uefi_get_pnvm(struct iwl_trans
err = efivar_entry_get(pnvm_efivar, NULL, &package_size, data);
if (err) {
IWL_DEBUG_FW(trans,
- "PNVM UEFI variable not found %d (len %zd)\n",
+ "PNVM UEFI variable not found %d (len %lu)\n",
err, package_size);
kfree(data);
data = ERR_PTR(err);
goto out;
}
- IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
+ IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %lu\n", package_size);
*len = package_size;
out:
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c
2021-08-21 2:09 [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c Randy Dunlap
@ 2021-09-05 19:07 ` Randy Dunlap
2021-09-06 7:21 ` Coelho, Luciano
2021-09-06 10:03 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-09-05 19:07 UTC (permalink / raw)
To: netdev
Cc: kernel test robot, Kalle Valo, Luca Coelho, linux-wireless,
David S. Miller, Jakub Kicinski
On 8/20/21 7:09 PM, Randy Dunlap wrote:
> The kernel test robot reports printk format warnings in uefi.c, so
> correct them.
>
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
> 52 | "PNVM UEFI variable not found %d (len %zd)\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 53 | err, package_size);
> | ~~~~~~~~~~~~
> | |
> | long unsigned int
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
> 59 | IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
> | |
> | long unsigned int
>
> Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210820.orig/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> +++ linux-next-20210820/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> @@ -49,14 +49,14 @@ void *iwl_uefi_get_pnvm(struct iwl_trans
> err = efivar_entry_get(pnvm_efivar, NULL, &package_size, data);
> if (err) {
> IWL_DEBUG_FW(trans,
> - "PNVM UEFI variable not found %d (len %zd)\n",
> + "PNVM UEFI variable not found %d (len %lu)\n",
> err, package_size);
> kfree(data);
> data = ERR_PTR(err);
> goto out;
> }
>
> - IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> + IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %lu\n", package_size);
> *len = package_size;
>
> out:
>
Hm, no one has commented on this and the robot is still reporting it as
build warnings.
Do I need to resend it?
thanx.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c
2021-09-05 19:07 ` Randy Dunlap
@ 2021-09-06 7:21 ` Coelho, Luciano
0 siblings, 0 replies; 4+ messages in thread
From: Coelho, Luciano @ 2021-09-06 7:21 UTC (permalink / raw)
To: rdunlap, netdev; +Cc: linux-wireless, kuba, kvalo, lkp, davem
On Sun, 2021-09-05 at 12:07 -0700, Randy Dunlap wrote:
> On 8/20/21 7:09 PM, Randy Dunlap wrote:
> > The kernel test robot reports printk format warnings in uefi.c, so
> > correct them.
> >
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
> > 52 | "PNVM UEFI variable not found %d (len %zd)\n",
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 53 | err, package_size);
> > | ~~~~~~~~~~~~
> > | |
> > | long unsigned int
> > ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
> > 59 | IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
> > | |
> > | long unsigned int
> >
> > Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Cc: Kalle Valo <kvalo@codeaurora.org>
> > Cc: Luca Coelho <luciano.coelho@intel.com>
> > Cc: linux-wireless@vger.kernel.org
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > ---
> > drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- linux-next-20210820.orig/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> > +++ linux-next-20210820/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
> > @@ -49,14 +49,14 @@ void *iwl_uefi_get_pnvm(struct iwl_trans
> > err = efivar_entry_get(pnvm_efivar, NULL, &package_size, data);
> > if (err) {
> > IWL_DEBUG_FW(trans,
> > - "PNVM UEFI variable not found %d (len %zd)\n",
> > + "PNVM UEFI variable not found %d (len %lu)\n",
> > err, package_size);
> > kfree(data);
> > data = ERR_PTR(err);
> > goto out;
> > }
> >
> >
> > - IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> > + IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %lu\n", package_size);
> > *len = package_size;
> >
> >
> > out:
> >
>
> Hm, no one has commented on this and the robot is still reporting it as
> build warnings.
> Do I need to resend it?
No need to resend. Kalle, can you take this directly to wireless-
drivers? I have assigned it to you in patchwork.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: iwlwifi: fix printk format warnings in uefi.c
2021-08-21 2:09 [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c Randy Dunlap
2021-09-05 19:07 ` Randy Dunlap
@ 2021-09-06 10:03 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-09-06 10:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, Randy Dunlap, kernel test robot, Luca Coelho,
linux-wireless, David S. Miller, Jakub Kicinski
Randy Dunlap <rdunlap@infradead.org> wrote:
> The kernel test robot reports printk format warnings in uefi.c, so
> correct them.
>
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
> 52 | "PNVM UEFI variable not found %d (len %zd)\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 53 | err, package_size);
> | ~~~~~~~~~~~~
> | |
> | long unsigned int
> ../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
> 59 | IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
> | |
> | long unsigned int
>
> Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
Patch applied to wireless-drivers.git, thanks.
e4457a45b41c iwlwifi: fix printk format warnings in uefi.c
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210821020901.25901-1-rdunlap@infradead.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-06 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 2:09 [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c Randy Dunlap
2021-09-05 19:07 ` Randy Dunlap
2021-09-06 7:21 ` Coelho, Luciano
2021-09-06 10:03 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).