* [PATCH] brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet
@ 2021-09-28 16:06 Hans de Goede
2021-10-05 5:31 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-09-28 16:06 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo,
Chi-Hsien Lin, Chung-hsien Hsu
Cc: Hans de Goede, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list
The Cyberbook T116 tablet contains quite generic names in the sys_vendor
and product_name DMI strings, without this patch brcmfmac will try to load:
"brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which
is way too generic.
The nvram file shipped on the factory Android image contains the exact
same settings as those used on the AcePC T8 mini PC, so point the new
DMI nvram filename quirk to the acepc-t8 nvram file.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index 6d5188b78f2d..0af452dca766 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -75,6 +75,16 @@ static const struct dmi_system_id dmi_platform_data[] = {
},
.driver_data = (void *)&acepc_t8_data,
},
+ {
+ /* Cyberbook T116 rugged tablet */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "20170531"),
+ },
+ /* The factory image nvram file is identical to the ACEPC T8 one */
+ .driver_data = (void *)&acepc_t8_data,
+ },
{
/* Match for the GPDwin which unfortunately uses somewhat
* generic dmi strings, which is why we test for 4 strings.
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet
2021-09-28 16:06 [PATCH] brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet Hans de Goede
@ 2021-10-05 5:31 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-10-05 5:31 UTC (permalink / raw)
To: Hans de Goede
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Chung-hsien Hsu, Hans de Goede, linux-wireless,
brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
Hans de Goede <hdegoede@redhat.com> wrote:
> The Cyberbook T116 tablet contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which
> is way too generic.
>
> The nvram file shipped on the factory Android image contains the exact
> same settings as those used on the AcePC T8 mini PC, so point the new
> DMI nvram filename quirk to the acepc-t8 nvram file.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
49c3eb3036e6 brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210928160633.96928-1-hdegoede@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 5:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 16:06 [PATCH] brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet Hans de Goede
2021-10-05 5:31 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).