* [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
@ 2021-10-18 3:31 Yang Yingliang
2021-10-18 3:39 ` Pkshih
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yang Yingliang @ 2021-10-18 3:31 UTC (permalink / raw)
To: linux-kernel, netdev, linux-wireless; +Cc: pkshih, kuba, davem, kvalo
Fix the return value check which testing the wrong variable
in rtw89_cam_send_sec_key_cmd().
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wireless/realtek/rtw89/cam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/cam.c b/drivers/net/wireless/realtek/rtw89/cam.c
index c1e8c76c6aca..ad7a8155dbed 100644
--- a/drivers/net/wireless/realtek/rtw89/cam.c
+++ b/drivers/net/wireless/realtek/rtw89/cam.c
@@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev,
return 0;
ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true);
- if (!skb) {
+ if (!ext_skb) {
rtw89_err(rtwdev, "failed to get ext sec key command\n");
return -ENOMEM;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
2021-10-18 3:31 [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() Yang Yingliang
@ 2021-10-18 3:39 ` Pkshih
2021-10-18 12:16 ` Kalle Valo
2021-10-20 8:49 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Pkshih @ 2021-10-18 3:39 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, netdev, linux-wireless; +Cc: kuba, davem, kvalo
> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: Monday, October 18, 2021 11:31 AM
> To: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-wireless@vger.kernel.org
> Cc: Pkshih <pkshih@realtek.com>; kuba@kernel.org; davem@davemloft.net; kvalo@codeaurora.org
> Subject: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
>
> Fix the return value check which testing the wrong variable
> in rtw89_cam_send_sec_key_cmd().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/cam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/cam.c
> b/drivers/net/wireless/realtek/rtw89/cam.c
> index c1e8c76c6aca..ad7a8155dbed 100644
> --- a/drivers/net/wireless/realtek/rtw89/cam.c
> +++ b/drivers/net/wireless/realtek/rtw89/cam.c
> @@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev,
> return 0;
>
> ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true);
> - if (!skb) {
> + if (!ext_skb) {
> rtw89_err(rtwdev, "failed to get ext sec key command\n");
> return -ENOMEM;
> }
> --
> 2.25.1
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
2021-10-18 3:31 [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() Yang Yingliang
2021-10-18 3:39 ` Pkshih
@ 2021-10-18 12:16 ` Kalle Valo
2021-10-18 12:40 ` Yang Yingliang
2021-10-20 8:49 ` Kalle Valo
2 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2021-10-18 12:16 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, linux-wireless, pkshih, kuba, davem
Yang Yingliang <yangyingliang@huawei.com> wrote:
> Fix the return value check which testing the wrong variable
> in rtw89_cam_send_sec_key_cmd().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
rtw89 patches are applied wireless-drivers-next, not net-next. rtw89 is not
even in net-next yet.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211018033102.1813058-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
2021-10-18 12:16 ` Kalle Valo
@ 2021-10-18 12:40 ` Yang Yingliang
0 siblings, 0 replies; 5+ messages in thread
From: Yang Yingliang @ 2021-10-18 12:40 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, netdev, linux-wireless, pkshih, kuba, davem
Hi,
On 2021/10/18 20:16, Kalle Valo wrote:
> Yang Yingliang <yangyingliang@huawei.com> wrote:
>
>> Fix the return value check which testing the wrong variable
>> in rtw89_cam_send_sec_key_cmd().
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> rtw89 patches are applied wireless-drivers-next, not net-next. rtw89 is not
> even in net-next yet.
It should be -next.
Thanks,
Yang
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
2021-10-18 3:31 [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() Yang Yingliang
2021-10-18 3:39 ` Pkshih
2021-10-18 12:16 ` Kalle Valo
@ 2021-10-20 8:49 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-10-20 8:49 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, linux-wireless, pkshih, kuba, davem
Yang Yingliang <yangyingliang@huawei.com> wrote:
> Fix the return value check which testing the wrong variable
> in rtw89_cam_send_sec_key_cmd().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
a04310edcd00 rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211018033102.1813058-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-20 8:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 3:31 [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd() Yang Yingliang
2021-10-18 3:39 ` Pkshih
2021-10-18 12:16 ` Kalle Valo
2021-10-18 12:40 ` Yang Yingliang
2021-10-20 8:49 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).