linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Exuvo <exuvo@exuvo.se>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Helmut Schaa <helmut.schaa@googlemail.com>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: rt2x00 regression
Date: Wed, 10 Nov 2021 09:01:41 +0100	[thread overview]
Message-ID: <20211110080141.GA123566@wp.pl> (raw)
In-Reply-To: <87wnlgo5rp.fsf@codeaurora.org>

On Wed, Nov 10, 2021 at 08:59:22AM +0200, Kalle Valo wrote:
> Stanisław Gruszka <stf_xl@wp.pl> writes:
> 
> > Dnia 9 listopada 2021 16:22 Exuvo <exuvo@exuvo.se> napisał(a):
> >
> >  Just tested it and it passes the rt2x00lib_load_firmware but still errors on
> >  rt2800usb_set_device_state:
> >
> > <snip>
> >
> >  @@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status)
> >    else
> >    rt2x00dev->num_proto_errs = 0;
> >   
> >  - if (rt2x00dev->num_proto_errs > 3)
> >  + if (rt2x00dev->num_proto_errs > 3 &&
> >  +    !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags))
> >    return true;
> >   
> >    return false;
> >
> > Sorry, I screwed logic in my patch. It should be test_bit() instead of !test_bit(). 
> > And also we should not count when device did not start. So patch should be somewhat different. I'll
> > send tomorrow hopefully better patch. 
> 
> No HTML, please :) I'll reply so that lists see your email.

Eh, I sent from my phone to give quick update, did not realize
it send in HTML.

Anyway, below is updated patch. I hope it will work correctly now.

Regards 
Stanislaw

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
index e4473a551241..74c3d8cb3100 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
@@ -25,6 +25,9 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status)
 	if (status == -ENODEV || status == -ENOENT)
 		return true;
 
+	if (!test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags))
+		return false;
+
 	if (status == -EPROTO || status == -ETIMEDOUT)
 		rt2x00dev->num_proto_errs++;
 	else



  reply	other threads:[~2021-11-10  8:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 16:32 Anton Olsson
2019-09-27  8:03 ` Stanislaw Gruszka
     [not found]   ` <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com>
2019-12-03  7:57     ` Stanislaw Gruszka
2019-12-03 18:50       ` Anton Olsson
2020-04-05  4:58         ` Anton Olsson
2020-07-15 19:47           ` Anton Olsson
2021-09-29  8:22             ` Exuvo
2021-10-01  6:56               ` Kalle Valo
2021-11-05 13:25                 ` Thorsten Leemhuis
2021-11-08 18:00                   ` Thorsten Leemhuis
     [not found]                     ` <20211109073127.ga109212@wp.pl>
2021-11-09  7:31                     ` Stanislaw Gruszka
2021-11-09 12:07                       ` Stanislaw Gruszka
2021-11-09 15:22                         ` Exuvo
     [not found]                           ` <cc85b4e8a038417b865069c6578acf50@grupawp.pl>
2021-11-10  6:59                             ` Kalle Valo
2021-11-10  8:01                               ` Stanislaw Gruszka [this message]
2021-11-11 10:54                                 ` Exuvo
2021-11-11 14:10                                   ` [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Stanislaw Gruszka
2021-11-18  6:16                                     ` Thorsten Leemhuis
2021-11-19 14:19                                       ` Kalle Valo
2021-11-29 10:54                                     ` Kalle Valo
     [not found] <ca+gwt0b5syrznglqwqoeujk4cwmvc=dkawre9vn8kqc6kbzkgw@mail.gmail.com>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110080141.GA123566@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=exuvo@exuvo.se \
    --cc=helmut.schaa@googlemail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=sgruszka@redhat.com \
    --subject='Re: rt2x00 regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).