* [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const
@ 2022-01-09 23:09 Colin Ian King
2022-01-31 15:49 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-01-09 23:09 UTC (permalink / raw)
To: Solomon Peachy, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
Don't populate the read-only array queue_id_to_wmm_aci on the stack
but instead make it static. Also makes the object code a little smaller.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/st/cw1200/wsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/st/cw1200/wsm.c b/drivers/net/wireless/st/cw1200/wsm.c
index 99624dd34886..5a3e7a626702 100644
--- a/drivers/net/wireless/st/cw1200/wsm.c
+++ b/drivers/net/wireless/st/cw1200/wsm.c
@@ -537,7 +537,7 @@ int wsm_set_tx_queue_params(struct cw1200_common *priv,
{
int ret;
struct wsm_buf *buf = &priv->wsm_cmd_buf;
- u8 queue_id_to_wmm_aci[] = {3, 2, 0, 1};
+ static const u8 queue_id_to_wmm_aci[] = { 3, 2, 0, 1 };
wsm_cmd_lock(priv);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const
2022-01-09 23:09 [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const Colin Ian King
@ 2022-01-31 15:49 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-01-31 15:49 UTC (permalink / raw)
To: Colin Ian King
Cc: Solomon Peachy, David S . Miller, Jakub Kicinski, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> wrote:
> Don't populate the read-only array queue_id_to_wmm_aci on the stack
> but instead make it static. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Patch applied to wireless-next.git, thanks.
fe683faecc7a cw1200: wsm: make array queue_id_to_wmm_aci static const
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220109230921.58766-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-31 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-09 23:09 [PATCH] cw1200: wsm: make array queue_id_to_wmm_aci static const Colin Ian King
2022-01-31 15:49 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).