* [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address
@ 2022-07-01 8:29 Xu Qiang
2022-07-27 13:01 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Xu Qiang @ 2022-07-01 8:29 UTC (permalink / raw)
To: srini.raju, kvalo, davem, edumazet, kuba, pabeni
Cc: linux-wireless, netdev, linux-kernel, xuqiang36, rui.xiang
Using eth_zero_addr() to assign zero address instead of memset().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
---
v2:
- fix typo in commit log
drivers/net/wireless/purelifi/plfxlc/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c
index 8519cf0adfff..39e54b3787d6 100644
--- a/drivers/net/wireless/purelifi/plfxlc/usb.c
+++ b/drivers/net/wireless/purelifi/plfxlc/usb.c
@@ -562,7 +562,7 @@ static void sta_queue_cleanup_timer_callb(struct timer_list *t)
if (tx->station[sidx].flag & STATION_HEARTBEAT_FLAG) {
tx->station[sidx].flag ^= STATION_HEARTBEAT_FLAG;
} else {
- memset(tx->station[sidx].mac, 0, ETH_ALEN);
+ eth_zero_addr(tx->station[sidx].mac);
tx->station[sidx].flag = 0;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address
2022-07-01 8:29 [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address Xu Qiang
@ 2022-07-27 13:01 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-07-27 13:01 UTC (permalink / raw)
To: Xu Qiang
Cc: srini.raju, davem, edumazet, kuba, pabeni, linux-wireless,
netdev, linux-kernel, xuqiang36, rui.xiang
Xu Qiang <xuqiang36@huawei.com> wrote:
> Using eth_zero_addr() to assign zero address instead of memset().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
Patch applied to wireless-next.git, thanks.
70c898d4bad1 wifi: plfxlc: Use eth_zero_addr() to assign zero address
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220701082935.110924-1-xuqiang36@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-27 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-01 8:29 [PATCH v2 -next] wifi: plfxlc: Use eth_zero_addr() to assign zero address Xu Qiang
2022-07-27 13:01 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).