* [PATCH] iwlegacy: Remove the unused variable len
@ 2023-11-10 7:36 Jiapeng Chong
2023-11-10 18:17 ` Stanislaw Gruszka
2023-11-14 10:18 ` wifi: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-11-10 7:36 UTC (permalink / raw)
To: stf_xl; +Cc: kvalo, linux-wireless, linux-kernel, Jiapeng Chong, Abaci Robot
Variable len is not effectively used, so delete it.
drivers/net/wireless/intel/iwlegacy/4965-mac.c:4234:7: warning: variable 'len' set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7223
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 69276266ce6f..70e420df1643 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -4231,8 +4231,6 @@ il4965_rx_handle(struct il_priv *il)
fill_rx = 1;
while (i != r) {
- int len;
-
rxb = rxq->queue[i];
/* If an RXB doesn't have a Rx queue slot associated with it,
@@ -4246,10 +4244,6 @@ il4965_rx_handle(struct il_priv *il)
PAGE_SIZE << il->hw_params.rx_page_order,
DMA_FROM_DEVICE);
pkt = rxb_addr(rxb);
-
- len = le32_to_cpu(pkt->len_n_flags) & IL_RX_FRAME_SIZE_MSK;
- len += sizeof(u32); /* account for status word */
-
reclaim = il_need_reclaim(il, pkt);
/* Based on type of command response or notification,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: Remove the unused variable len
2023-11-10 7:36 [PATCH] iwlegacy: Remove the unused variable len Jiapeng Chong
@ 2023-11-10 18:17 ` Stanislaw Gruszka
2023-11-14 10:18 ` wifi: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2023-11-10 18:17 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: kvalo, linux-wireless, linux-kernel, Abaci Robot
On Fri, Nov 10, 2023 at 03:36:02PM +0800, Jiapeng Chong wrote:
> Variable len is not effectively used, so delete it.
>
> drivers/net/wireless/intel/iwlegacy/4965-mac.c:4234:7: warning: variable 'len' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7223
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: iwlegacy: Remove the unused variable len
2023-11-10 7:36 [PATCH] iwlegacy: Remove the unused variable len Jiapeng Chong
2023-11-10 18:17 ` Stanislaw Gruszka
@ 2023-11-14 10:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-11-14 10:18 UTC (permalink / raw)
To: Jiapeng Chong
Cc: stf_xl, linux-wireless, linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Variable len is not effectively used, so delete it.
>
> drivers/net/wireless/intel/iwlegacy/4965-mac.c:4234:7: warning: variable 'len' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7223
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-next.git, thanks.
af3077af7c07 wifi: iwlegacy: Remove the unused variable len
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231110073602.16846-1-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-14 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 7:36 [PATCH] iwlegacy: Remove the unused variable len Jiapeng Chong
2023-11-10 18:17 ` Stanislaw Gruszka
2023-11-14 10:18 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).