* [PATCH] brcmfmac: avoid gcc-5.1 warning
@ 2015-05-12 21:54 Arnd Bergmann
2015-05-26 10:54 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-05-12 21:54 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Pieter-Paul Giesberts, John W. Linville, linux-wireless,
brcm80211-dev-list, Brett Rudley, Franky Lin, Hante Meuleman,
linux-arm-kernel, netdev
gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac
driver:
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process':
drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
This is a false positive, and marking the brcmf_fws_hanger_poppkt function
as 'static inline' makes the warning go away. I have checked the object
file output and while a little code gets moved around, the size of
the binary remains identical.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found while building the ARM imx_v6_v7_defconfig configuration with gcc-5.
We try to get all ARM defconfigs to build without warnings normally.
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
index f0dda0ecd23b..5017eaa4af45 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c
@@ -635,7 +635,7 @@ static int brcmf_fws_hanger_pushpkt(struct brcmf_fws_hanger *h,
return 0;
}
-static int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h,
+static inline int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h,
u32 slot_id, struct sk_buff **pktout,
bool remove_item)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: brcmfmac: avoid gcc-5.1 warning
2015-05-12 21:54 [PATCH] brcmfmac: avoid gcc-5.1 warning Arnd Bergmann
@ 2015-05-26 10:54 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-05-26 10:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arend Van Spriel, Pieter-Paul Giesberts, John W. Linville,
linux-wireless, brcm80211-dev-list, Brett Rudley, Franky Lin,
Hante Meuleman, linux-arm-kernel, netdev
> gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac
> driver:
>
> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process':
> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> This is a false positive, and marking the brcmf_fws_hanger_poppkt function
> as 'static inline' makes the warning go away. I have checked the object
> file output and while a little code gets moved around, the size of
> the binary remains identical.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-26 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-12 21:54 [PATCH] brcmfmac: avoid gcc-5.1 warning Arnd Bergmann
2015-05-26 10:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).