* [PATCH] staging: wilc1000: Remove unused function wilc_lock_timeout
@ 2016-10-20 8:54 Binoy Jayan
2016-10-20 9:17 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Binoy Jayan @ 2016-10-20 8:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Aditya Shankar, Ganesh Krishna
Cc: Arnd Bergmann, linux-wireless, linux-kernel, Binoy Jayan
Semaphore are going away in the future, so remove the unused function
wilc_lock_timeout which calls a semaphore api but has no users.
Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
---
They following is a patch which removes semaphores from wilc1000.
Its part of a bigger effort to eliminate all semaphores
from the linux kernel.
drivers/staging/wilc1000/linux_wlan.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 6370a5e..470d59f 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -218,17 +218,6 @@ static void deinit_irq(struct net_device *dev)
}
}
-int wilc_lock_timeout(struct wilc *nic, void *vp, u32 timeout)
-{
- /* FIXME: replace with mutex_lock or wait_for_completion */
- int error = -1;
-
- if (vp)
- error = down_timeout(vp,
- msecs_to_jiffies(timeout));
- return error;
-}
-
void wilc_mac_indicate(struct wilc *wilc, int flag)
{
int status;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wilc1000: Remove unused function wilc_lock_timeout
2016-10-20 8:54 [PATCH] staging: wilc1000: Remove unused function wilc_lock_timeout Binoy Jayan
@ 2016-10-20 9:17 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-20 9:17 UTC (permalink / raw)
To: Binoy Jayan
Cc: Greg Kroah-Hartman, Aditya Shankar, Ganesh Krishna,
linux-wireless, linux-kernel
On Thursday, October 20, 2016 2:24:32 PM CEST Binoy Jayan wrote:
> Semaphore are going away in the future, so remove the unused function
> wilc_lock_timeout which calls a semaphore api but has no users.
>
> Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
> ---
>
> They following is a patch which removes semaphores from wilc1000.
> Its part of a bigger effort to eliminate all semaphores
> from the linux kernel.
Good catch!
> drivers/staging/wilc1000/linux_wlan.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 6370a5e..470d59f 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -218,17 +218,6 @@ static void deinit_irq(struct net_device *dev)
> }
> }
>
> -int wilc_lock_timeout(struct wilc *nic, void *vp, u32 timeout)
> -{
> - /* FIXME: replace with mutex_lock or wait_for_completion */
> - int error = -1;
> -
> - if (vp)
> - error = down_timeout(vp,
> - msecs_to_jiffies(timeout));
> - return error;
> -}
You need to remove the prototype from wilc_wfi_netdevice.h
as well. Once you do that, please add
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-20 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20 8:54 [PATCH] staging: wilc1000: Remove unused function wilc_lock_timeout Binoy Jayan
2016-10-20 9:17 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).