From: Yuehaibing <yuehaibing@huawei.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: <davem@davemloft.net>, <pradeepc@codeaurora.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<ath11k@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath11k: thermal: Fix build error without CONFIG_THERMAL
Date: Tue, 7 Apr 2020 10:01:47 +0800 [thread overview]
Message-ID: <2c636eaf-7672-353c-80b2-1649b3a94e60@huawei.com> (raw)
In-Reply-To: <87mu7ozs1c.fsf@kamboji.qca.qualcomm.com>
On 2020/4/6 21:02, Kalle Valo wrote:
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> drivers/net/wireless/ath/ath11k/thermal.h:45:1:
>> warning: no return statement in function returning non-void [-Wreturn-type]
>> drivers/net/wireless/ath/ath11k/core.c:416:28: error:
>> passing argument 1 of ‘ath11k_thermal_unregister’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>>
>> Add missing return 0 in ath11k_thermal_set_throttling,
>> and fix ath11k_thermal_unregister param type.
>
> These are warnings, no? "build error" and "compiler warning" are
> different things, the former breaks the whole build which is super
> critical, but I'll queue this to v5.7 nevertheless. And I'll change the
> title to:
>
> ath11k: fix compiler warning without CONFIG_THERMAL
Ok , thanks!
>
next prev parent reply other threads:[~2020-04-07 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:34 [PATCH] ath11k: thermal: Fix build error without CONFIG_THERMAL YueHaibing
2020-04-06 13:02 ` Kalle Valo
2020-04-07 2:01 ` Yuehaibing [this message]
2020-04-06 14:22 ` [PATCH] ath11k: fix compiler warnings " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c636eaf-7672-353c-80b2-1649b3a94e60@huawei.com \
--to=yuehaibing@huawei.com \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).