From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <davem@davemloft.net>, <pradeepc@codeaurora.org>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH] ath11k: fix compiler warnings without CONFIG_THERMAL
Date: Mon, 6 Apr 2020 14:22:07 +0000 (UTC) [thread overview]
Message-ID: <20200406142207.CB6BFC43636@smtp.codeaurora.org> (raw)
In-Reply-To: <20200403083414.31392-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> drivers/net/wireless/ath/ath11k/thermal.h:45:1:
> warning: no return statement in function returning non-void [-Wreturn-type]
> drivers/net/wireless/ath/ath11k/core.c:416:28: error:
> passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types]
>
> Add missing return 0 in ath11k_thermal_set_throttling,
> and fix ath11k_thermal_unregister param type.
>
> Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers.git, thanks.
c9be1a642a7b ath11k: fix compiler warnings without CONFIG_THERMAL
--
https://patchwork.kernel.org/patch/11472105/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-04-06 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:34 [PATCH] ath11k: thermal: Fix build error without CONFIG_THERMAL YueHaibing
2020-04-06 13:02 ` Kalle Valo
2020-04-07 2:01 ` Yuehaibing
2020-04-06 14:22 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406142207.CB6BFC43636@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).