From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <rafal@milecki.pl>,
linux-mips@linux-mips.org, "Christoph Hellwig" <hch@lst.de>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [PATCH wireless-drivers-next] bcma: get SoC device struct & copy its DMA params to the subdevices
Date: Wed, 22 Dec 2021 20:11:15 -0800 [thread overview]
Message-ID: <2f6de5b7-65ac-ee6a-e0ef-4635f1808379@gmail.com> (raw)
In-Reply-To: <20190121101121.24555-1-zajec5@gmail.com>
On 1/21/2019 2:11 AM, RafaB MiBecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> For bus devices to be fully usable it's required to set their DMA
> parameters.
>
> For years it has been missing and remained unnoticed because of
> mips_dma_alloc_coherent() silently handling the empty coherent_dma_mask.
> Kernel 4.19 came with a lot of DMA changes and caused a regression on
> the bcm47xx. Starting with the commit f8c55dc6e828 ("MIPS: use generic
> dma noncoherent ops for simple noncoherent platforms") DMA coherent
> allocations just fail. Example:
> [ 1.114914] bgmac_bcma bcma0:2: Allocation of TX ring 0x200 failed
> [ 1.121215] bgmac_bcma bcma0:2: Unable to alloc memory for DMA
> [ 1.127626] bgmac_bcma: probe of bcma0:2 failed with error -12
> [ 1.133838] bgmac_bcma: Broadcom 47xx GBit MAC driver loaded
>
> This change fixes above regression in addition to the MIPS bcm47xx
> commit 321c46b91550 ("MIPS: BCM47XX: Setup struct device for the SoC").
>
> It also fixes another *old* GPIO regression caused by a parent pointing
> to the NULL:
> [ 0.157054] missing gpiochip .dev parent pointer
> [ 0.157287] bcma: bus0: Error registering GPIO driver: -22
> introduced by the commit 74f4e0cc6108 ("bcma: switch GPIO portions to
> use GPIOLIB_IRQCHIP").
>
> Fixes: f8c55dc6e828 ("MIPS: use generic dma noncoherent ops for simple noncoherent platforms")
> Fixes: 74f4e0cc6108 ("bcma: switch GPIO portions to use GPIOLIB_IRQCHIP")
> Cc: linux-mips@linux-mips.org
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> While this patch is a regression fix, it depends on a change present in
> the wireless-drivers-next.git:
> bcma: keep a direct pointer to the struct device
Rafal, there was supposed to be a v2, but I could not find one, this is
the regression that prevented bgmac_bcma from loading while testing
upstream, did you have a v2 ready already to be submitted somehow?
Thanks!
--
Florian
next prev parent reply other threads:[~2021-12-23 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 10:11 [PATCH wireless-drivers-next] bcma: get SoC device struct & copy its DMA params to the subdevices Rafał Miłecki
2019-01-21 14:46 ` Christoph Hellwig
2019-01-23 18:00 ` Rafał Miłecki
2021-12-23 4:11 ` Florian Fainelli [this message]
2021-12-23 6:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6de5b7-65ac-ee6a-e0ef-4635f1808379@gmail.com \
--to=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hch@lst.de \
--cc=kvalo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).