* [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro
@ 2016-10-12 18:08 Alan
2016-10-12 21:32 ` Steve deRosier
2016-10-13 11:20 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Alan @ 2016-10-12 18:08 UTC (permalink / raw)
To: linux-wireless
From: Adam Williamson <adamw@happyassassin.net>
SDIO ID 0271:0418
Signed-off-by: Alan Cox <alan@linux.intel.com>
Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921
diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
index eab0ab9..76eb336 100644
--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
+ {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
{},
};
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro
2016-10-12 18:08 [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro Alan
@ 2016-10-12 21:32 ` Steve deRosier
2016-10-13 4:50 ` Kalle Valo
2016-10-13 11:20 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Steve deRosier @ 2016-10-12 21:32 UTC (permalink / raw)
To: Alan; +Cc: linux-wireless
Hi Alan,
Sorry to quibble, but the subsystem label on the commit subject line
should be "ath6kl:" it's a lower-case "L", not a one.
On Wed, Oct 12, 2016 at 11:08 AM, Alan <alan@linux.intel.com> wrote:
> From: Adam Williamson <adamw@happyassassin.net>
>
> SDIO ID 0271:0418
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921
>
> diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
> index eab0ab9..76eb336 100644
> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
> {},
> };
>
>
I see nothing wrong with this if the chip does indeed identify itself
this way. So please fix the subject and you can add:
Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com>
- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro
2016-10-12 21:32 ` Steve deRosier
@ 2016-10-13 4:50 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2016-10-13 4:50 UTC (permalink / raw)
To: Steve deRosier; +Cc: Alan, linux-wireless
Steve deRosier <derosier@gmail.com> writes:
> Sorry to quibble, but the subsystem label on the commit subject line
> should be "ath6kl:" it's a lower-case "L", not a one.
Heh, I missed that :) I can fix it before I commit.
>> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
>> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
>> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
>> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
>> {},
>> };
>>
>>
>
> I see nothing wrong with this if the chip does indeed identify itself
> this way. So please fix the subject and you can add:
>
> Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com>
Thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro
2016-10-12 18:08 [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro Alan
2016-10-12 21:32 ` Steve deRosier
@ 2016-10-13 11:20 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2016-10-13 11:20 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-wireless
Alan Cox <alan@linux.intel.com> wrote:
> From: Adam Williamson <adamw@happyassassin.net>
>
> SDIO ID 0271:0418
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921
> Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com>
>
> diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
> index eab0ab9..76eb336 100644
> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
> {},
> };
>
Patch applied to ath-current branch of ath.git, thanks.
1ea2643961b0 ath6kl: add Dell OEM SDIO I/O for the Venue 8 Pro
--
https://patchwork.kernel.org/patch/9373725/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-13 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 18:08 [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro Alan
2016-10-12 21:32 ` Steve deRosier
2016-10-13 4:50 ` Kalle Valo
2016-10-13 11:20 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).