From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@adapt-ip.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 07/22] mac80211: s1g: choose scanning width based on frequency
Date: Fri, 18 Sep 2020 12:40:49 +0200 [thread overview]
Message-ID: <43afe1ee1067d77aa6be5765e02f3cf0549c7c8f.camel@sipsolutions.net> (raw)
In-Reply-To: <20200831205600.21058-8-thomas@adapt-ip.com>
On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
> An S1G BSS can beacon at either 1 or 2 MHz and the channel
> width is unique to a given frequency. Ignore scan channel
> width for now and use the allowed channel width.
>
> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
> ---
> net/mac80211/scan.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c
> index 5ac2785cdc7b..5002791fe165 100644
> --- a/net/mac80211/scan.c
> +++ b/net/mac80211/scan.c
> @@ -905,6 +905,17 @@ static void ieee80211_scan_state_set_channel(struct ieee80211_local *local,
> local->scan_chandef.center_freq1 = chan->center_freq;
> local->scan_chandef.freq1_offset = chan->freq_offset;
> local->scan_chandef.center_freq2 = 0;
> +
> + /* For scanning on the S1G band, ignore scan_width (which is constant
> + * across all channels) for now since channel width is specific to each
> + * channel. Detect the required channel width here and likely revisit
> + * later. Maybe scan_width could be used to build the channel scan list?
> + */
> + if (chan->band == NL80211_BAND_S1GHZ) {
> + local->scan_chandef.width = ieee80211_s1g_channel_width(chan);
> + goto set_channel;
> + }
nit: double space after 'goto'
but really I came to say that this probably changes then, if you don't
convince me about the stuff in the previous patch review? :)
So I'm leaving this patch also for now - have applied 1-5 so far.
johannes
next prev parent reply other threads:[~2020-09-18 10:40 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 20:55 [PATCH v2 00/22] add support for S1G association Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 01/22] ieee80211: redefine S1G bits with GENMASK Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 02/22] nl80211: advertise supported channel width in S1G Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 03/22] cfg80211: regulatory: handle S1G channels Thomas Pedersen
2020-09-05 18:38 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 04/22] nl80211: correctly validate S1G beacon head Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 05/22] nl80211: support setting S1G channels Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 06/22] {cfg,mac}80211: get correct default channel width for S1G Thomas Pedersen
2020-09-18 10:38 ` Johannes Berg
2020-09-21 4:59 ` Thomas Pedersen
2020-09-21 7:01 ` Johannes Berg
2020-09-21 16:26 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 07/22] mac80211: s1g: choose scanning width based on frequency Thomas Pedersen
2020-09-18 10:40 ` Johannes Berg [this message]
2020-09-21 5:06 ` Thomas Pedersen
2020-09-21 6:58 ` Johannes Berg
2020-08-31 20:55 ` [PATCH v2 08/22] nl80211: support S1G capabilities Thomas Pedersen
2020-09-18 10:41 ` Johannes Berg
2020-09-18 10:47 ` Johannes Berg
2020-09-21 4:34 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 09/22] mac80211: support S1G STA capabilities Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 10/22] cfg80211: convert S1G beacon to scan results Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 11/22] cfg80211: parse S1G Operation element for BSS channel Thomas Pedersen
2020-09-18 10:45 ` Johannes Berg
2020-09-21 5:12 ` Thomas Pedersen
2020-09-21 6:54 ` Johannes Berg
2020-08-31 20:55 ` [PATCH v2 12/22] mac80211: convert S1G beacon to scan results Thomas Pedersen
2020-09-18 10:48 ` Johannes Berg
2020-09-21 5:45 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 13/22] cfg80211: handle Association Response from S1G STA Thomas Pedersen
2020-09-18 10:50 ` Johannes Berg
2020-09-21 5:52 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 14/22] mac80211: encode listen interval for S1G Thomas Pedersen
2020-09-18 10:51 ` Johannes Berg
2020-09-21 5:56 ` Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 15/22] mac80211: don't calculate duration " Thomas Pedersen
2020-09-18 10:52 ` Johannes Berg
2020-09-18 10:55 ` Johannes Berg
2020-09-21 6:03 ` Thomas Pedersen
2020-09-21 6:51 ` Johannes Berg
2020-08-31 20:55 ` [PATCH v2 16/22] mac80211: handle S1G low rates Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 17/22] mac80211: avoid rate init for S1G band Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 18/22] mac80211: receive and process S1G beacons Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 19/22] mac80211: support S1G association Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 20/22] nl80211: include frequency offset in survey info Thomas Pedersen
2020-08-31 20:55 ` [PATCH v2 21/22] mac80211_hwsim: indicate support for S1G Thomas Pedersen
2020-09-06 8:49 ` [mac80211_hwsim] 8cafe19852: hwsim.fst_ap_config_default.fail kernel test robot
2020-09-08 18:00 ` Thomas Pedersen
2020-09-08 18:41 ` Johannes Berg
2020-09-08 18:53 ` Thomas Pedersen
2020-08-31 20:56 ` [PATCH v2 22/22] mac80211_hwsim: fix TSF timestamp write to S1G beacon Thomas Pedersen
2020-09-06 16:04 ` [PATCH v2 00/22] add support for S1G association Johannes Berg
2020-09-08 18:30 ` Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43afe1ee1067d77aa6be5765e02f3cf0549c7c8f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@adapt-ip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).