From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Sven Eckelmann <sven@narfation.org>, ath11k@lists.infradead.org
Cc: Rajkumar Manoharan <rmanohar@codeaurora.org>,
linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
kvalo@codeaurora.org
Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics
Date: Tue, 5 May 2020 17:37:27 +0200 [thread overview]
Message-ID: <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> (raw)
In-Reply-To: <1845755.pTfhzBy2qg@bentobox>
On 5/5/20 9:49 AM, Sven Eckelmann wrote:
> On Tuesday, 5 May 2020 09:01:34 CEST Sven Eckelmann wrote:
>> On Tuesday, 5 May 2020 01:46:12 CEST Rajkumar Manoharan wrote:
>> [...]
>>> IIRC this was fixed a while ago by below patch. Somehow it never landed
>>> in ath.git.
>>> Simple one line change is enough.
>>>
>>> https://patchwork.kernel.org/patch/10550707/
>> Because it doesn't work for everything. Remember that 10.2.4.x overflows all
>> the time (14-30s) because it used only 31 bit for the counters.
>>
>> But feel free to point me to the firmware version which fixed this.
> See also https://patchwork.kernel.org/patch/9701459/
>
> Kind regards,
> Sven
This patch already fixes the problem for me. I tested it on QCA988X hw
with firmware 10.2.4.
[ 10.350919] ath10k_pci 0000:04:00.0: qca988x hw2.0 target 0x4100016c
chip_id 0x043222ff sub 0000:0000
[ 10.350930] ath10k_pci 0000:04:00.0: kconfig debug 1 debugfs 1
tracing 1 dfs 0 testmode 0
[ 10.351803] ath10k_pci 0000:04:00.0: firmware ver 10.2.4-1.0-00047
api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 35bd9258
[ 10.385617] ath10k_pci 0000:04:00.0: board_file api 1 bmi_id N/A
crc32 bebc7c08
[ 11.536818] ath10k_pci 0000:04:00.0: htt-ver 2.1 wmi-op 5 htt-op 2
cal otp max-sta 128 raw 0 hwcrypto 1
I also did not see the 31 bit overflow after a small amount of seconds.
Survey data from wlp4s0
frequency: 2412 MHz [in use]
noise: -65 dBm
channel active time: 5370225 ms
channel busy time: 924199 ms
channel receive time: 140 ms
channel transmit time: 0 ms
Kind regards,
Markus
next prev parent reply other threads:[~2020-05-05 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:41 [PATCH 1/2] ath10k: use cumulative survey statistics Markus Theil
2020-05-04 15:41 ` [PATCH 2/2] ath11k: " Markus Theil
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-05 6:53 ` Markus Theil
2020-05-05 17:31 ` Rajkumar Manoharan
2020-05-04 16:29 ` [PATCH 1/2] ath10k: " Sven Eckelmann
2020-05-04 16:33 ` Markus Theil
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:52 ` Rajkumar Manoharan
2020-05-05 0:02 ` Ben Greear
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 15:37 ` Markus Theil [this message]
2020-05-05 18:32 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).