From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Markus Theil <markus.theil@tu-ilmenau.de>,
linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
kvalo@codeaurora.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics
Date: Mon, 04 May 2020 16:52:45 -0700 [thread overview]
Message-ID: <4b03993ba81a8e9ebb1203c0b8aa90f6@codeaurora.org> (raw)
In-Reply-To: <323b4d4f-a967-cf63-6f5a-04f53802c50a@candelatech.com>
On 2020-05-04 16:49, Ben Greear wrote:
> On 05/04/2020 04:46 PM, Rajkumar Manoharan wrote:
>> On 2020-05-04 08:41, Markus Theil wrote:
>>> ath10k currently reports survey results for the last interval between
>>> each
>>> invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations,
>>> this
>>> can lead to unexpectedly small results, e.g. when hostapd uses survey
>>> data and iw survey dump is invoked in parallel. Fix this by returning
>>> cumulative results, that don't depend on the last invocation. Other
>>> drivers, e.g. ath9k or mt76 also use this behavior.
>>>
>>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
>>>
>>
>> IIRC this was fixed a while ago by below patch. Somehow it never
>> landed in ath.git.
>> Simple one line change is enough.
>>
>> https://patchwork.kernel.org/patch/10550707/
>>
>> -Rajkumar
>
> Have you tested this with wave-1? Lots of older, at least, firmware
> has brokenness in this area.
>
Yes. It was tested in wave-1 as well. Venkat replied to your comment on
original change.
-Rajkumar
next prev parent reply other threads:[~2020-05-04 23:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:41 [PATCH 1/2] ath10k: use cumulative survey statistics Markus Theil
2020-05-04 15:41 ` [PATCH 2/2] ath11k: " Markus Theil
2020-05-04 16:36 ` Sven Eckelmann
2020-05-04 23:37 ` Rajkumar Manoharan
2020-05-05 6:53 ` Markus Theil
2020-05-05 17:31 ` Rajkumar Manoharan
2020-05-04 16:29 ` [PATCH 1/2] ath10k: " Sven Eckelmann
2020-05-04 16:33 ` Markus Theil
2020-05-04 23:46 ` Rajkumar Manoharan
2020-05-04 23:49 ` Ben Greear
2020-05-04 23:52 ` Rajkumar Manoharan [this message]
2020-05-05 0:02 ` Ben Greear
2020-05-05 7:01 ` Sven Eckelmann
2020-05-05 7:49 ` Sven Eckelmann
2020-05-05 7:55 ` Sven Eckelmann
2020-05-05 18:45 ` Rajkumar Manoharan
2020-05-05 15:37 ` Markus Theil
2020-05-05 18:32 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b03993ba81a8e9ebb1203c0b8aa90f6@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).