RE: [RFC] mwifiex: block work queue while suspended

From: Bing Zhao <bzhao@marvell.com>
To: "quozl@laptop.org" <quozl@laptop.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [RFC] mwifiex: block work queue while suspended
Date: Tue, 27 May 2014 21:35:21 -0700	[thread overview]
Message-ID: <477F20668A386D41ADCC57781B1F70430F70F5E4B3@SC-VEXCH1.marvell.com> (raw)
In-Reply-To: <20140528020128.GG4151@us.netrek.org>

Hi James,

> > > We use a GPIO to wake from WLAN.
> >
> > This doesn't match the gpio parameter configured in hscfg command
> > 0xe5.
> 
> You're right, and I'm quite wrong.  Sorry about that.  I misread our
> code.
> 
> Correction, we use SDIO to wake from WLAN.
> 
> We set gap to 0xff, which we think is a special value that means the
> device will wait for the host to acknowledge before sending data to
> the host.

Yes, gap=0xff should be used. Actually I also have the patch to set gap to 0xff queued in my local tree. I will send it upstream.

> 
> Looking through history of development, we thought that this would
> avoid a race condition, where the host starts to suspend, configures
> the device for host sleep, but the device may wake in the time before
> the host suspends.
> 
> We don't see this "mmc0: Timeout waiting for hardware interrupt."
> problem unless we use WPA2.  It does not reproduce on an open access
> point.

With WPA2 enabled, does the "mmc0 timeout" happen in every suspend attempt?

Thanks,
Bing