From: Bing Zhao <bzhao@marvell.com>
To: "quozl@laptop.org" <quozl@laptop.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [RFC] mwifiex: block work queue while suspended
Date: Tue, 27 May 2014 22:04:51 -0700 [thread overview]
Message-ID: <477F20668A386D41ADCC57781B1F70430F70F5E4CC@SC-VEXCH1.marvell.com> (raw)
In-Reply-To: <20140528044945.GI4151@us.netrek.org>
Hi James,
> > > We set gap to 0xff, which we think is a special value that means the
> > > device will wait for the host to acknowledge before sending data to
> > > the host.
> >
> > Yes, gap=0xff should be used. Actually I also have the patch to set
> > gap to 0xff queued in my local tree. I will send it upstream.
>
> Thanks. Today I have been testing with gap 50ms and no longer able to
> reproduce the "mmc0: Timeout waiting for hardware interrupt." problem.
Hmm, that's interesting.
The concern of none-0xff gap was that the SDIO interrupt could come in without acknowledgement from host. As long as XO-4 system (specifically mmc subsystem) can wake up within 50ms you are fine.
>
> > > Looking through history of development, we thought that this would
> > > avoid a race condition, where the host starts to suspend, configures
> > > the device for host sleep, but the device may wake in the time before
> > > the host suspends.
> > >
> > > We don't see this "mmc0: Timeout waiting for hardware interrupt."
> > > problem unless we use WPA2. It does not reproduce on an open access
> > > point.
> >
> > With WPA2 enabled, does the "mmc0 timeout" happen in every suspend
> > attempt?
>
> No, it is rare, of the order of one in every 6000 attempts, and depends
> on the timing of arriving packets. Our reproducer uses a ping ramp,
> with interval varying from 0.1 to 0.9 seconds with 50ms increment, and
> this brings the problem frequency down to about one in 200 attempts.
>
> The OLPC XO-4 by default tries to suspend automatically when user is
> idle, which is why we notice the problem.
Good to know.
Thanks,
Bing
next prev parent reply other threads:[~2014-05-28 5:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 1:24 [RFC] mwifiex: block work queue while suspended James Cameron
2014-05-22 3:50 ` Bing Zhao
2014-05-22 5:46 ` James Cameron
2014-05-23 4:12 ` Bing Zhao
2014-05-26 8:01 ` James Cameron
2014-05-27 23:39 ` Bing Zhao
2014-05-28 2:01 ` James Cameron
2014-05-28 4:35 ` Bing Zhao
2014-05-28 4:49 ` James Cameron
2014-05-28 5:04 ` Bing Zhao [this message]
2014-05-29 1:22 ` James Cameron
2014-05-29 2:10 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477F20668A386D41ADCC57781B1F70430F70F5E4CC@SC-VEXCH1.marvell.com \
--to=bzhao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=quozl@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).