* [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined
@ 2017-07-03 12:27 Stefan Assmann
2017-07-04 11:01 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Assmann @ 2017-07-03 12:27 UTC (permalink / raw)
To: devel; +Cc: linux-wireless, sassmann
Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_sec_ie’:
drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: ‘ndissecuritytype’ undeclared (first use in thisfunction)
Remove the no longer existing parameter.
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 9e35573..f97f35a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2498,8 +2498,7 @@ sint rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in
uint ndisauthmode = psecuritypriv->ndisauthtype;
RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
- ("+rtw_restruct_sec_ie: ndisauthmode =%d ndissecuritytype =%d\n",
- ndisauthmode, ndissecuritytype));
+ ("+rtw_restruct_sec_ie: ndisauthmode =%d\n", ndisauthmode));
/* copy fixed ie only */
memcpy(out_ie, in_ie, 12);
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined
2017-07-03 12:27 [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined Stefan Assmann
@ 2017-07-04 11:01 ` Kalle Valo
2017-07-04 15:58 ` Stefan Assmann
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2017-07-04 11:01 UTC (permalink / raw)
To: Stefan Assmann; +Cc: devel, linux-wireless
Stefan Assmann <sassmann@kpanic.de> writes:
> Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
> CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
> In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
> drivers/staging/rtl8723bs/core/rtw_mlme.c: In function =E2=80=98rtw_restr=
uct_sec_ie=E2=80=99:
> drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: =E2=80=98ndisse=
curitytype=E2=80=99 undeclared (first use in thisfunction)
>
> Remove the no longer existing parameter.
>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Please use prefix "staging:" for staging patches.
--=20
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined
2017-07-04 11:01 ` Kalle Valo
@ 2017-07-04 15:58 ` Stefan Assmann
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Assmann @ 2017-07-04 15:58 UTC (permalink / raw)
To: Kalle Valo; +Cc: devel, linux-wireless
On 04.07.2017 13:01, Kalle Valo wrote:
> Stefan Assmann <sassmann@kpanic.de> writes:
>
>> Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
>> CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
>> In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
>> drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_sec_ie’:
>> drivers/staging/rtl8723bs/core/rtw_mlme.c:2502:19: error: ‘ndissecuritytype’ undeclared (first use in thisfunction)
>>
>> Remove the no longer existing parameter.
>>
>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>
> Please use prefix "staging:" for staging patches.
>
OK, will keep that in mind next time.
Thanks!
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-04 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03 12:27 [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined Stefan Assmann
2017-07-04 11:01 ` Kalle Valo
2017-07-04 15:58 ` Stefan Assmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).