From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>,
Christian Lamparter <chunkeey@web.de>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFT] p54: implement rfkill
Date: Fri, 07 Aug 2009 11:39:40 -0500 [thread overview]
Message-ID: <4A7C58CC.2040708@lwfinger.net> (raw)
In-Reply-To: <20090807153602.GG7545@tuxdriver.com>
John W. Linville wrote:
> On Sun, Jul 19, 2009 at 11:54:15PM +0200, Christian Lamparter wrote:
>> This patch gets rid of the deprecated radio_enabled
>>
>> fwio.c: In function ‘p54_setup_mac’:
>> fwio.c:323: warning: ‘radio_enabled’ is deprecated (declared at include/net/mac80211.h:607)
>
> Anyone had a chance to test this? And report the results to Christian?
Sorry - I missed this one.
I just tested it. With the patch, the warning is removed. As far as
system operation, the following is observed:
1. If b43 is loaded when using p54usb, then the hardware switch will
kill operation. This behavior is the same with or without this patch.
2. If b43 is unloaded, then p54usb no longer follows the hardware
switch, but operation can be killed with the rfkill user-space
utility. Again, this behavior does not depend on the patch.
Based on the code changes in the patch, it looks as if the radio is
turned off when the device is blocked, but I have no way to test that.
Christian - please add a
Tested-by: Larry Finger <Larry.Finger@lwfinger.net> to the patch and
submit. This change should be in 2.6.32.
Larry
next prev parent reply other threads:[~2009-08-07 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 21:54 [RFT] p54: implement rfkill Christian Lamparter
2009-08-07 15:36 ` John W. Linville
2009-08-07 16:39 ` Larry Finger [this message]
2009-08-19 14:41 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7C58CC.2040708@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).