From: Larry Finger <Larry.Finger@lwfinger.net>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae
Date: Sat, 5 Jan 2019 15:34:24 -0600 [thread overview]
Message-ID: <4a34b41e-1c18-14af-b398-396dfd9823d7@lwfinger.net> (raw)
In-Reply-To: <DB7PR07MB53536F93922110AAB221480AE48F0@DB7PR07MB5353.eurprd07.prod.outlook.com>
On 1/5/19 12:38 PM, Bernd Edlinger wrote:
> Currently the rtl8723ae driver is broken (since v4.7).
>
> Connection to AP is lost very often, especially when
> the signal level is not very good.
>
> The main issue is the power save mode is basically
> not working, and seems to trigger a firmware bug.
> So I had to take out the FW LPS mode handling.
>
> While debugging the driver I found a couple related issues,
> for instance that the signal level in dm.undec_sm_pwdb
> is no longer accurate (may be even much too high) when no more
> packets are received, and it increases the likelihood to receive
> something if the input gain is set to maximum.
>
> The patch was tested with the rtl8723ae PCI card in my laptop
> against a FRITZ!Box 7590 AP -- the WiFi connection works now
> very reliable for me.
>
> V2 of the patch adjusts the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
>
>
> Bernd Edlinger (4):
> rtlwifi: rtl8723ae: Take the FW LPS mode handling out
> rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input gain control
> when no beacon was received in the connected state
> rtlwifi: rtl8723ae: Re-introduce
> rtl8723e_dm_refresh_rate_adaptive_mask
> rtlwifi: Move the clearing of rtlpriv->link_info.num_rx_inperiod in
> rtl_watchdog_wq_callback a few lines down
The subject on all 4 of these need to be modified. Only the first line will be
shown as the "subject", which will not make much sense.
In addition, you need to include the changes in the cover letter, and in the
actual patch after the --- line. In that section, you mention what changes were
made in each revision, then follow with another --- line. That info is there for
the maintainers - it will be stripped before the patch is merged.
Larry
prev parent reply other threads:[~2019-01-05 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 18:38 [PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae Bernd Edlinger
2019-01-05 21:34 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a34b41e-1c18-14af-b398-396dfd9823d7@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bernd.edlinger@hotmail.de \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).