From: Larry Finger <Larry.Finger@lwfinger.net>
To: Souptick Joarder <jrdr.linux@gmail.com>,
arend.vanspriel@broadcom.com, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5] rtlwifi: Replace hardcode value with macro
Date: Wed, 2 Aug 2017 09:35:37 -0500 [thread overview]
Message-ID: <4d6b58d1-3e26-e6ea-0c0e-7e2b7aa3b75e@lwfinger.net> (raw)
In-Reply-To: <20170802122915.GA4759@symbol-HP-ZBook-15>
On 08/02/2017 07:29 AM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro and removed the comment.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Finally!
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
@Kalle: I'm sure you can work around this, but patchwork shows two different
"v5" versions and a "v4" entry for this same patch. That may be due to no one
formally rejecting the patch.
Larry
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++---
> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index 8b833e2..ea18aa7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -426,9 +426,8 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>
> /* TODO: Correct this value for our hw */
> - /* TODO: define these hard code value */
> - hw->max_listen_interval = 10;
> - hw->max_rate_tries = 4;
> + hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> + hw->max_rate_tries = MAX_RATE_TRIES;
> /* hw->max_rates = 1; */
> hw->sta_data_size = sizeof(struct rtl_sta_info);
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
> index ab7d819..b56d1b7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
> @@ -65,6 +65,8 @@ enum ap_peer {
> #define FRAME_OFFSET_ADDRESS3 16
> #define FRAME_OFFSET_SEQUENCE 22
> #define FRAME_OFFSET_ADDRESS4 24
> +#define MAX_LISTEN_INTERVAL 10
> +#define MAX_RATE_TRIES 4
>
> #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
> WRITEEF2BYTE(_hdr, _val)
>
next prev parent reply other threads:[~2017-08-02 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 12:29 [PATCH v5] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-08-02 14:35 ` Larry Finger [this message]
2017-08-03 10:18 ` Kalle Valo
2017-08-03 10:43 ` Souptick Joarder
2017-08-03 10:21 ` [v5] " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 12:20 [PATCH v5] " Souptick Joarder
2017-08-02 12:22 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6b58d1-3e26-e6ea-0c0e-7e2b7aa3b75e@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jrdr.linux@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).