From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5] rtlwifi: Replace hardcode value with macro
Date: Thu, 03 Aug 2017 13:18:34 +0300 [thread overview]
Message-ID: <87fud9nedh.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4d6b58d1-3e26-e6ea-0c0e-7e2b7aa3b75e@lwfinger.net> (Larry Finger's message of "Wed, 2 Aug 2017 09:35:37 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 08/02/2017 07:29 AM, Souptick Joarder wrote:
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro and removed the comment.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Finally!
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> @Kalle: I'm sure you can work around this, but patchwork shows two
> different "v5" versions and a "v4" entry for this same patch. That may
> be due to no one formally rejecting the patch.
It's because Souptick submitted two v5 patches, but yeah I can that sort
it out.
Souptick, the idea with patch versions is that maintainers and reviewers
can easily find the latest version and drop the rest so ALWAYS increase
the version number. Submitting duplicate version numbers defeats the
purpose and creates extra work for others.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-03 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 12:29 [PATCH v5] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-08-02 14:35 ` Larry Finger
2017-08-03 10:18 ` Kalle Valo [this message]
2017-08-03 10:43 ` Souptick Joarder
2017-08-03 10:21 ` [v5] " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 12:20 [PATCH v5] " Souptick Joarder
2017-08-02 12:22 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fud9nedh.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).